Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-19024: remove featuregate upgradeable controller that moved to cluster-config-operator #1547

Merged
merged 1 commit into from Sep 19, 2023

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 14, 2023

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2023
@deads2k deads2k changed the title remove featuregate upgradeable controller that moved to cluster-config-operator OCPBUGS-19024: remove featuregate upgradeable controller that moved to cluster-config-operator Sep 14, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 14, 2023
@openshift-ci-robot
Copy link

@deads2k: This pull request references Jira Issue OCPBUGS-19024, which is invalid:

  • expected the bug to target the "4.15.0" version, but it targets "4.15" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This controller moved to https://github.com/openshift/cluster-config-operator/tree/master/pkg/operator/featureupgradablecontroller in 4.14

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor Author

deads2k commented Sep 14, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 14, 2023
@openshift-ci-robot
Copy link

@deads2k: This pull request references Jira Issue OCPBUGS-19024, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Sep 14, 2023

/payload-job periodic-ci-openshift-release-master-ci-4.15-e2e-aws-sdn-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2023

@wking: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-ci-4.15-e2e-aws-sdn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2cc61d50-5334-11ee-84d4-9b78032b55bb-0

Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2023
@dgrisonnet
Copy link
Member

/lgtm cancel

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2023
@deads2k
Copy link
Contributor Author

deads2k commented Sep 15, 2023

yes, thank you.

@deads2k
Copy link
Contributor Author

deads2k commented Sep 18, 2023

/retest

Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, dgrisonnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-single-node b1837ef link false /test e2e-gcp-operator-single-node
ci/prow/e2e-metal-single-node-live-iso b1837ef link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-aws-operator-disruptive-single-node b1837ef link false /test e2e-aws-operator-disruptive-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit feed511 into openshift:master Sep 19, 2023
12 of 15 checks passed
@openshift-ci-robot
Copy link

@deads2k: Jira Issue OCPBUGS-19024: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19024 has been moved to the MODIFIED state.

In response to this:

This controller moved to https://github.com/openshift/cluster-config-operator/tree/master/pkg/operator/featureupgradablecontroller in 4.14

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants