Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update required GV for ValidatingAdmissionPolicy gate. #1561

Merged
merged 1 commit into from Sep 29, 2023
Merged

Update required GV for ValidatingAdmissionPolicy gate. #1561

merged 1 commit into from Sep 29, 2023

Conversation

benluddy
Copy link
Contributor

In 1.29, ValidatingAdmissionPolicy requires admissionregistration.k8s.io/v1beta1, not admissionregistration.k8s.io/v1alpha1.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2023
@benluddy benluddy mentioned this pull request Sep 27, 2023
Merged
@benluddy
Copy link
Contributor Author

/test e2e-gcp-operator

@benluddy
Update required GV for ValidatingAdmissionPolicy gate.
4f92e41 
In 1.29, ValidatingAdmissionPolicy requires admissionregistration.k8s.io/v1beta1, not
admissionregistration.k8s.io/v1alpha1.
@benluddy benluddy force-pushed the validatingadmissionpolicy-v1beta1 branch from d98f847 to 4f92e41 Compare September 28, 2023 18:04
@benluddy
Copy link
Contributor Author

/retest-required

1 similar comment
@benluddy
Copy link
Contributor Author

/retest-required

@tkashem
Copy link
Contributor

tkashem commented Sep 29, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

@benluddy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 4f92e41 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-operator-disruptive-single-node 4f92e41 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-metal-single-node-live-iso 4f92e41 link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-gcp-operator-single-node 4f92e41 link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c1fb42c into openshift:master Sep 29, 2023
11 of 15 checks passed
@sjenning sjenning mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@sanchezl sanchezl Awaiting requested review from sanchezl

Assignees

@tkashem tkashem

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benluddy @tkashem @openshift-merge-robot