[release-4.14] OCPBUGS-22718: manifests/0000_90_kube-apiserver-operator_04_servicemonitor-apiserver: Rename to kube-apiserver-performance-recording-rules #1572
Conversation
…: Rename to kube-apiserver-performance-recording-rules Exactly like 7457da4 (manifests: rename API performance dashboard, 2023-10-10, openshift#1565), this pivot: * Turns the original (group, namepspace, name) into a delete manifest, with no capability annotation (all clusters should delete this resource). * Creates a (group, namespace, newName) manifest with the original spec content and capability annotation (only clusters with the cap enabled should have this resource). which allows updates like: 1. Old release with the old (group, namepspace, name) not annotated for a capability. 2. Request update to new release. 3. Outgoing cluster-version operator compares the outgoing manifests with the incoming manifests to decide if any capabilities need to be implicitly enabled: a. It sees that the old (group, namepspace, name) isn't labeled with any capabilities, so no need to implicitly enable anything there. b. It sees that the new (group, namespace, newName) is annotated for the capability, but it doesn't see anything with that g,n,n getting reconciled in the outgoing manifest set, so it thinks "just some new manifest for a capability I do not care about", and does not enable the annotated capability. In a separate pull request than 7457da4, because this one doesn't need to go back to 4.14. The RecordingRule is from 04f36e7 (manifests: add new PrometheusRule for recording rules, 2023-06-28, openshift#1521), which landed in 4.14, so 4.13 clusters do not have a matching (group, namespace, name) manifest to worry about matching.
|
@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-20331 with correct target version. Will retitle the PR to link to the clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-22718, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sdodson: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-22718. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #1566
/assign sdodson