Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: extend node-system-admin-client validity to 2 years #1618

Merged
merged 1 commit into from Feb 9, 2024
Merged

NO-JIRA: extend node-system-admin-client validity to 2 years #1618

merged 1 commit into from Feb 9, 2024

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Jan 8, 2024

This is necessary to test multi year time skew, so that CSRs could be approved using localhost-recovery kubeconfig

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vrutkovs
Copy link
Member Author

vrutkovs commented Jan 8, 2024

/test e2e-metal-ovn-sno-cert-rotation-suspend-180d
/test e2e-metal-ovn-sno-cert-rotation-shutdown-180d
/test e2e-metal-ovn-ha-cert-rotation-suspend-180d
/test e2e-metal-ovn-ha-cert-rotation-shutdown-180d
/test e2e-metal-ovn-sno-cert-rotation-suspend-360d
/test e2e-metal-ovn-sno-cert-rotation-shutdown-360d
/test e2e-metal-ovn-ha-cert-rotation-suspend-360d
/test e2e-metal-ovn-ha-cert-rotation-shutdown-360d

@vrutkovs vrutkovs mentioned this pull request Jan 8, 2024
Merged
@vrutkovs
Copy link
Member Author

/test e2e-metal-ovn-ha-cert-rotation-suspend-180d
/test e2e-metal-ovn-ha-cert-rotation-suspend-360d
/test e2e-metal-ovn-sno-cert-rotation-suspend-180d
/test e2e-metal-ovn-sno-cert-rotation-suspend-360d

1 similar comment
@vrutkovs
Copy link
Member Author

/test e2e-metal-ovn-ha-cert-rotation-suspend-180d
/test e2e-metal-ovn-ha-cert-rotation-suspend-360d
/test e2e-metal-ovn-sno-cert-rotation-suspend-180d
/test e2e-metal-ovn-sno-cert-rotation-suspend-360d

@vrutkovs
Copy link
Member Author

vrutkovs commented Feb 1, 2024

/test e2e-metal-ovn-sno-cert-rotation-suspend-30d
/test e2e-metal-ovn-sno-cert-rotation-suspend-180d
/test e2e-metal-ovn-sno-cert-rotation-suspend-360d
/test e2e-metal-ovn-sno-cert-rotation-shutdown-30d
/test e2e-metal-ovn-sno-cert-rotation-shutdown-180d
/test e2e-metal-ovn-sno-cert-rotation-shutdown-360d
/test e2e-metal-ovn-ha-cert-rotation-suspend-30d
/test e2e-metal-ovn-ha-cert-rotation-suspend-180d
/test e2e-metal-ovn-ha-cert-rotation-suspend-360d
/test e2e-metal-ovn-ha-cert-rotation-shutdown-30d
/test e2e-metal-ovn-ha-cert-rotation-shutdown-180d
/test e2e-metal-ovn-ha-cert-rotation-shutdown-360d

@vrutkovs
Copy link
Member Author

vrutkovs commented Feb 1, 2024

/test e2e-metal-ovn-sno-cert-rotation-suspend-180d
/test e2e-metal-ovn-sno-cert-rotation-suspend-360d
/test e2e-metal-ovn-ha-cert-rotation-shutdown-360d

@vrutkovs
Copy link
Member Author

vrutkovs commented Feb 1, 2024

/test e2e-metal-ovn-ha-cert-rotation-suspend-360d
/test e2e-metal-ovn-sno-cert-rotation-shutdown-180d
/test e2e-metal-ovn-sno-cert-rotation-shutdown-360d

@vrutkovs
Copy link
Member Author

vrutkovs commented Feb 1, 2024

/test e2e-metal-ovn-sno-cert-rotation-suspend-180d
/test e2e-metal-ovn-sno-cert-rotation-shutdown-180d

@vrutkovs
Copy link
Member Author

vrutkovs commented Feb 1, 2024

/test e2e-metal-ovn-sno-cert-rotation-shutdown-360d
/test e2e-metal-ovn-ha-cert-rotation-suspend-360d
/test e2e-metal-ovn-sno-cert-rotation-suspend-360d

@vrutkovs
Copy link
Member Author

vrutkovs commented Feb 2, 2024

/test e2e-metal-ovn-sno-cert-rotation-suspend-1y
/test e2e-metal-ovn-sno-cert-rotation-suspend-2y
/test e2e-metal-ovn-sno-cert-rotation-suspend-3y

@vrutkovs
Copy link
Member Author

vrutkovs commented Feb 2, 2024

/test e2e-metal-ovn-ha-cert-rotation-suspend-360d
/test e2e-metal-ovn-sno-cert-rotation-suspend-1y

@vrutkovs
Copy link
Member Author

vrutkovs commented Feb 5, 2024

/test e2e-metal-ovn-sno-cert-rotation-suspend-360d
/test e2e-metal-ovn-sno-cert-rotation-shutdown-360d
/test e2e-metal-ovn-sno-cert-rotation-suspend-1y
/test e2e-metal-ovn-sno-cert-rotation-suspend-2y
/test e2e-metal-ovn-sno-cert-rotation-suspend-3y

@vrutkovs
Copy link
Member Author

vrutkovs commented Feb 5, 2024

/test e2e-metal-ovn-sno-cert-rotation-suspend-3y

@vrutkovs
Copy link
Member Author

vrutkovs commented Feb 5, 2024

/test e2e-metal-ovn-sno-cert-rotation-suspend-2y

@vrutkovs
Copy link
Member Author

vrutkovs commented Feb 5, 2024

/test e2e-metal-ovn-sno-cert-rotation-suspend-1y

@vrutkovs
extend node-system-admin-client validity to 2 years
55b4eec 
This is necessary to test multi year time skew, so that CSRs could be approved using localhost-recovery kubeconfig
@vrutkovs vrutkovs force-pushed the extend-node-system-admin-validity branch from 956683d to 55b4eec Compare February 5, 2024 15:50
@vrutkovs vrutkovs changed the title extend node-system-admin-client validity to 5 years NO-JIRA: extend node-system-admin-client validity to 2 years Feb 5, 2024
@openshift-ci-robot
Copy link

@vrutkovs: This pull request explicitly references no jira issue.

In response to this:

This is necessary to test multi year time skew, so that CSRs could be approved using localhost-recovery kubeconfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 5, 2024
@vrutkovs vrutkovs marked this pull request as ready for review February 5, 2024 15:50
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2024
@vrutkovs
Copy link
Member Author

vrutkovs commented Feb 5, 2024

/test e2e-metal-ovn-sno-cert-rotation-suspend-30d
/test e2e-metal-ovn-sno-cert-rotation-suspend-180d
/test e2e-metal-ovn-sno-cert-rotation-suspend-360d
/test e2e-metal-ovn-sno-cert-rotation-shutdown-30d
/test e2e-metal-ovn-sno-cert-rotation-shutdown-180d
/test e2e-metal-ovn-sno-cert-rotation-shutdown-360d
/test e2e-metal-ovn-ha-cert-rotation-suspend-30d
/test e2e-metal-ovn-ha-cert-rotation-suspend-180d
/test e2e-metal-ovn-ha-cert-rotation-suspend-360d
/test e2e-metal-ovn-ha-cert-rotation-shutdown-30d
/test e2e-metal-ovn-ha-cert-rotation-shutdown-180d
/test e2e-metal-ovn-ha-cert-rotation-shutdown-360d

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 5, 2024 •
edited

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ovn-sno-cert-rotation-suspend-360d 956683d link false /test e2e-metal-ovn-sno-cert-rotation-suspend-360d
ci/prow/e2e-aws-operator-disruptive-single-node 55b4eec link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-aws-ovn-single-node 55b4eec link false /test e2e-aws-ovn-single-node
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown-360d 55b4eec link false /test e2e-metal-ovn-ha-cert-rotation-shutdown-360d
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown-360d 55b4eec link false /test e2e-metal-ovn-sno-cert-rotation-shutdown-360d
ci/prow/e2e-metal-ovn-sno-cert-rotation-suspend-2y 956683d link false /test e2e-metal-ovn-sno-cert-rotation-suspend-2y
ci/prow/e2e-gcp-operator-single-node 55b4eec link false /test e2e-gcp-operator-single-node
ci/prow/e2e-metal-ovn-sno-cert-rotation-suspend-3y 956683d link false /test e2e-metal-ovn-sno-cert-rotation-suspend-3y
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown-180d 55b4eec link false /test e2e-metal-ovn-ha-cert-rotation-shutdown-180d
ci/prow/e2e-metal-ovn-ha-cert-rotation-suspend-360d 55b4eec link false /test e2e-metal-ovn-ha-cert-rotation-suspend-360d
ci/prow/e2e-metal-ovn-sno-cert-rotation-suspend-1y 956683d link false /test e2e-metal-ovn-sno-cert-rotation-suspend-1y

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Member Author

vrutkovs commented Feb 9, 2024

/retest-required

dgrisonnet
dgrisonnet approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dgrisonnet,vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit adfd7d1 into openshift:master Feb 9, 2024
15 of 22 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.16.0-202402092208.p0.gadfd7d1.assembly.stream.el9 for distgit ose-cluster-kube-apiserver-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet dgrisonnet approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

@sanchezl sanchezl Awaiting requested review from sanchezl

Assignees

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vrutkovs @openshift-ci-robot @openshift-bot @dgrisonnet