Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBSDA-553: add provider name to cluster_infrastructure_provider when external platform #1638

Merged
merged 1 commit into from Feb 9, 2024
Merged

OBSDA-553: add provider name to cluster_infrastructure_provider when external platform #1638

merged 1 commit into from Feb 9, 2024

Conversation

rccrdpccl
Copy link
Contributor

This will help track installations for third party platform (such as OCI) integrating through external platform

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2024 •
edited by openshift-ci bot

@rccrdpccl: This pull request references OBSDA-553 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target the "4.16.0" version, but no target version was set.

In response to this:

This will help track installations for third party platform (such as OCI) integrating through external platform

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rccrdpccl
Copy link
Contributor Author

/cc @adriengentil

@rccrdpccl
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2024
@rccrdpccl rccrdpccl force-pushed the OBSDA-553-add-platform-name-for-external-platform branch 2 times, most recently from fe67968 to 8561852 Compare February 7, 2024 15:36
@rccrdpccl
Copy link
Contributor Author

Couldn't really avoid adding another label as it would break compatibility

@rccrdpccl
Copy link
Contributor Author

/retest

2 similar comments
@rccrdpccl
Copy link
Contributor Author

/retest

@rccrdpccl
Copy link
Contributor Author

/retest

@rccrdpccl
OBSDA-553: add provider name to cluster_infrastructure_provider when …
2fc3681 
…platform external

Signed-off-by: Riccardo Piccoli <rpiccoli@redhat.com>
@rccrdpccl rccrdpccl force-pushed the OBSDA-553-add-platform-name-for-external-platform branch from 8561852 to 2fc3681 Compare February 8, 2024 12:43
@rccrdpccl
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 8, 2024

@rccrdpccl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-single-node 2fc3681 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node 2fc3681 link false /test e2e-aws-operator-disruptive-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

vrutkovs
vrutkovs approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rccrdpccl, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2a9e959 into openshift:master Feb 9, 2024
13 of 15 checks passed
@rccrdpccl
Copy link
Contributor Author

/cherry-pick release-4.15

@rccrdpccl
Copy link
Contributor Author

/cherry-pick release-4.16

@rccrdpccl
Copy link
Contributor Author

/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link

@rccrdpccl: new pull request created: #1639

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Feb 9, 2024
Merged
Closed
@openshift-cherrypick-robot
Copy link

@rccrdpccl: new pull request created: #1640

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 9, 2024
Closed
@openshift-cherrypick-robot
Copy link

@rccrdpccl: new pull request created: #1641

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rccrdpccl
Copy link
Contributor Author

/cherry-pick release-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 22, 2024
Merged
@openshift-cherrypick-robot
Copy link

@rccrdpccl: new pull request created: #1657

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrutkovs vrutkovs vrutkovs approved these changes

@adriengentil adriengentil Awaiting requested review from adriengentil

@deads2k deads2k Awaiting requested review from deads2k

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

Assignees

@vrutkovs vrutkovs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rccrdpccl @openshift-ci-robot @openshift-cherrypick-robot @vrutkovs