Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.14] OCPBUGS-29722: webhookcontroller: report when a webhook resource is missing a caBundle provided by the service-ca-operator #1646

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #1587

/assign wangke19

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-24005 has been cloned as Jira Issue OCPBUGS-29722. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-29722: webhookcontroller: report when a webhook resource is missing a caBundle provided by the service-ca-operator

In response to this:

This is an automated cherry-pick of #1587

/assign wangke19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-24005: webhookcontroller: report when a webhook resource is missing a caBundle provided by the service-ca-operator [release-4.14] OCPBUGS-29722: webhookcontroller: report when a webhook resource is missing a caBundle provided by the service-ca-operator Feb 20, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 20, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-29722, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1587

/assign wangke19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link

Jira issue https://issues.redhat.com/browse/OCPQE-19214 requires this fix

@wangke19
Copy link

/retest

@wangke19
Copy link

/test images

@wangke19
Copy link

/test e2e-azure-ovn

@wangke19
Copy link

/test e2e-gcp-operator-single-node

@wangke19
Copy link

/test e2e-aws-ovn-upgrade

@wangke19
Copy link

/test e2e-aws-operator-disruptive-single-node

Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node 6f8bc84 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-gcp-operator-single-node 6f8bc84 link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wangke19
Copy link

/assign @p0lyn0mial

@wangke19
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
@wangke19
Copy link

@p0lyn0mial Please help review the pr when you are free. It is required by one Jira issue https://issues.redhat.com/browse/OCPQE-19214. Thanks.

@wangke19
Copy link

/jira refresh

@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-29722, which is invalid:

  • expected dependent Jira Issue OCPBUGS-27490 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is Closed (Duplicate) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link

/jira refresh

@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-29722, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link

/jira refresh

@wangke19
Copy link

wangke19 commented Feb 21, 2024

Pre-merge verified the associated bug, got the expected results. Detail see https://issues.redhat.com/browse/OCPBUGS-29722?focusedId=24205553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-24205553,
/label qe-approved

Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

@wangke19: The label(s) /label qe-approved. cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

Pre-merge verified the associated bug, got the expected results. Detail see https://issues.redhat.com/browse/OCPBUGS-29722?focusedId=24205553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-24205553,
/label qe-approved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wangke19
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 21, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-29722, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-27491 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-27491 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @wangke19

In response to this:

This is an automated cherry-pick of #1587

/assign wangke19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@p0lyn0mial
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, p0lyn0mial, wangke19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024
@p0lyn0mial
Copy link
Contributor

feel free to also backport #1647 (once merges)

@wangke19
Copy link

Wait until this pr 1647 is merged before back-porting to 4.14

@wangke19
Copy link

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2024
@wangke19
Copy link

wangke19 commented Mar 5, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2024
@wangke19
Copy link

wangke19 commented Mar 5, 2024

#1647 has not been merged.
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2024
@wangke19
Copy link

wangke19 commented Mar 5, 2024

#1647 has been merged.
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2024
@wangke19
Copy link

wangke19 commented Mar 5, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 5, 2024
@tkashem
Copy link
Contributor

tkashem commented Mar 5, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9aae543 into openshift:release-4.14 Mar 5, 2024
13 of 15 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-29722: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29722 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #1587

/assign wangke19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@p0lyn0mial
Copy link
Contributor

Wait until this pr #1647 is merged before back-porting to 4.14

opened #1650

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.14.0-202403051609.p0.g9aae543.assembly.stream.el8 for distgit ose-cluster-kube-apiserver-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2024-03-06-185545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants