Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.14] OCPBUGS-33930: add a controller that reconciles SCCs' volumes #1681

Merged
merged 2 commits into from
May 21, 2024
Merged

[4.14] OCPBUGS-33930: add a controller that reconciles SCCs' volumes #1681

merged 2 commits into from
May 21, 2024

Conversation

stlaz
Copy link
Contributor

@stlaz stlaz commented May 20, 2024

Manual backport of #1675 that's had conflicts in vendor/modules.txt

/assign @deads2k

stlaz added 2 commits May 20, 2024 09:32
@stlaz
add a controller that reconciles SCCs' volumes
268e65e 
The storage team added "ephemeral" and "csi" volumes to all SCCs
somewhere around OCP version 4.13. However, since the past us set
SCCs as "create-only" (due to the legacy permission system),
meaning the CVO won't reconcile the SCCs, this change
never made it to upgraded clusters' SCCs. People that lack SCC update
privileges were installing odd operators they found on the internets
in hope to fix their SCC issues.

Introduce a controller that adds these volumes to all SCCs that the
CVO does not automatically reconcile.
@stlaz
go mod tidy && go mod vendor
6956952
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 20, 2024
@openshift-ci-robot
Copy link

@stlaz: This pull request references Jira Issue OCPBUGS-33930, which is invalid:

  • expected the bug to target either version "4.14." or "openshift-4.14.", but it targets "4.15.z" instead
  • expected dependent Jira Issue OCPBUGS-33697 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual backport of #1675 that's had conflicts in vendor/modules.txt

/assign @deads2k

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and tkashem May 20, 2024 07:40
@stlaz
Copy link
Contributor Author

stlaz commented May 20, 2024

/jira refresh

@openshift-ci-robot
Copy link

@stlaz: This pull request references Jira Issue OCPBUGS-33930, which is invalid:

  • expected dependent Jira Issue OCPBUGS-33697 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stlaz
Copy link
Contributor Author

stlaz commented May 20, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 20, 2024
@xingxingxia
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 20, 2024
@p0lyn0mial
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
@sdodson
Copy link
Member

sdodson commented May 20, 2024

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2024 •
edited
Loading

@stlaz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node 6956952 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-gcp-operator-single-node 6956952 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-ovn-single-node 6956952 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stlaz
Copy link
Contributor Author

stlaz commented May 21, 2024

/jira refresh
/retest-required

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 21, 2024
@openshift-ci-robot
Copy link

@stlaz: This pull request references Jira Issue OCPBUGS-33930, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-33697 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-33697 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact:
/cc @dpuniaredhat

In response to this:

/jira refresh
/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from dpuniaredhat May 21, 2024 10:40
@openshift-merge-bot openshift-merge-bot bot merged commit 4302637 into openshift:release-4.14 May 21, 2024
12 of 15 checks passed
@openshift-ci-robot
Copy link

@stlaz: Jira Issue OCPBUGS-33930: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33930 has been moved to the MODIFIED state.

In response to this:

Manual backport of #1675 that's had conflicts in vendor/modules.txt

/assign @deads2k

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.14.0-202405211408.p0.g4302637.assembly.stream.el8 for distgit ose-cluster-kube-apiserver-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@tkashem tkashem Awaiting requested review from tkashem

@dpuniaredhat dpuniaredhat Awaiting requested review from dpuniaredhat

Assignees

@deads2k deads2k

@xingxingxia xingxingxia

@p0lyn0mial p0lyn0mial

@wangke19 wangke19

@gangwgr gangwgr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@stlaz @openshift-ci-robot @xingxingxia @p0lyn0mial @sdodson @openshift-bot @deads2k @wangke19 @gangwgr