Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable --enable-aggregator-routing by default #220

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Enable --enable-aggregator-routing by default #220

merged 1 commit into from
Jan 30, 2019

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Jan 25, 2019

Use endpoints IPs directly instead of service IPs, taking some of the networking logic out of the (stability) equation.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 25, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2019
@squeed
Copy link
Contributor

squeed commented Jan 25, 2019

👍

@squeed
Copy link
Contributor

squeed commented Jan 25, 2019

Further context: even if networking were long-run 100% reliable, kube-proxy still has non-zero convergence time. In times of apiserver disruption, this naturally can take longer, which would exacerbate any problems. This change takes one more component out of the critical path.

@sttts
Copy link
Contributor Author

sttts commented Jan 26, 2019

/retest

2 similar comments
@sttts
Copy link
Contributor Author

sttts commented Jan 28, 2019

/retest

@mfojtik
Copy link
Contributor

mfojtik commented Jan 28, 2019

/retest

soltysh
soltysh approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@deads2k fyi, we've struggled with this on Friday with Stefan when we encountered API server flapping again

@sttts sttts force-pushed the sttts-enable-aggregator-routing branch from edefee6 to b21db69 Compare January 30, 2019 09:21
@mfojtik
Copy link
Contributor

mfojtik commented Jan 30, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, soltysh, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts
Copy link
Contributor Author

sttts commented Jan 30, 2019

/retest

1 similar comment
@sttts
Copy link
Contributor Author

sttts commented Jan 30, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ad9c217 into openshift:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@mfojtik mfojtik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sttts @squeed @mfojtik @openshift-ci-robot @openshift-bot @soltysh @openshift-merge-robot