Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Encryption Config #516

Closed
wants to merge 97 commits into from
Closed

[WIP] Encryption Config #516

wants to merge 97 commits into from

Commits on Sep 18, 2019

  1. Encryption Config

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    73ced34 View commit details
    Browse the repository at this point in the history
  2. initial refactors

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    d228c32 View commit details
    Browse the repository at this point in the history
  3. add chunking to migration

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    b2efa89 View commit details
    Browse the repository at this point in the history
  4. fix progressing conditions

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    b94fea6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d4f27fd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ad2226f View commit details
    Browse the repository at this point in the history
  7. encryptionKeyController docs

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    4df4cc1 View commit details
    Browse the repository at this point in the history
  8. encryptionStateController docs

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    25fbd31 View commit details
    Browse the repository at this point in the history
  9. encryptionPruneController docs

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    8fd39c0 View commit details
    Browse the repository at this point in the history
  10. encryptionPodStateController docs

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    0b0c1e2 View commit details
    Browse the repository at this point in the history
  11. encryptionMigrationController docs

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    86e515d View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    b3d67a3 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    050bcdf View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    c734cf2 View commit details
    Browse the repository at this point in the history
  15. wip

    p0lyn0mial authored and enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    5d2475d View commit details
    Browse the repository at this point in the history
  16. Revert "wip"

    This reverts commit d894c2f.
    p0lyn0mial authored and enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    dcc25c5 View commit details
    Browse the repository at this point in the history
  17. clean up checkAndCreateKeys

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    e903a6a View commit details
    Browse the repository at this point in the history
  18. clean up needsNewKey

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    1bfcb3a View commit details
    Browse the repository at this point in the history
  19. nit

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    15fad6e View commit details
    Browse the repository at this point in the history
  20. improve getAPIServerRevisionOfAllInstances

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    dc4e50b View commit details
    Browse the repository at this point in the history
  21. make sure to retry when pods are not converged

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    f82b1a7 View commit details
    Browse the repository at this point in the history
  22. fix migration version hack

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    f7277c5 View commit details
    Browse the repository at this point in the history
  23. clean up write key logic

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    4bfef80 View commit details
    Browse the repository at this point in the history
  24. clean up lastMigrated calc

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    edac579 View commit details
    Browse the repository at this point in the history
  25. clean up setTimestampAnnotationIfNotSet

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    7343764 View commit details
    Browse the repository at this point in the history
  26. better decode failure msg

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    66b2846 View commit details
    Browse the repository at this point in the history
  27. uses operatorv1helpers.UpdateStaticPodStatus instead of operatorv1hel…

    …pers.UpdateStatus
    p0lyn0mial authored and enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    d98c2a4 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    839377c View commit details
    Browse the repository at this point in the history
  29. adds a happy path scenario that tests resources encryption and secret…

    …s annotation
    p0lyn0mial authored and enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    09cfec1 View commit details
    Browse the repository at this point in the history
  30. Wait for write observation

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    173f322 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    1572d13 View commit details
    Browse the repository at this point in the history
  32. wire fake discovery client

    p0lyn0mial authored and enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    aadf359 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    2f2639c View commit details
    Browse the repository at this point in the history
  34. add key lifetime doc

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    563b4c6 View commit details
    Browse the repository at this point in the history
  35. add label and annotation docs

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    80eed1d View commit details
    Browse the repository at this point in the history
  36. adds tests for status validation

    p0lyn0mial authored and enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    b8b5b4e View commit details
    Browse the repository at this point in the history
  37. update error msg

    p0lyn0mial authored and enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    5490810 View commit details
    Browse the repository at this point in the history
  38. comments and func names

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    b883424 View commit details
    Browse the repository at this point in the history
  39. better time logic

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    49c06aa View commit details
    Browse the repository at this point in the history
  40. more comments

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    1b59f1f View commit details
    Browse the repository at this point in the history
  41. TODO: finalizer

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    a50e3db View commit details
    Browse the repository at this point in the history
  42. TODO: optional safe?

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    523a2fa View commit details
    Browse the repository at this point in the history
  43. prevent encryption config explosion

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    5e3b04d View commit details
    Browse the repository at this point in the history
  44. handle progressing better

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    3ef51e1 View commit details
    Browse the repository at this point in the history
  45. TODO: progressing during migration

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    52ba113 View commit details
    Browse the repository at this point in the history
  46. TODO: docs and unit tests

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    24c8b81 View commit details
    Browse the repository at this point in the history
  47. TODO: support key mode

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    3314cfb View commit details
    Browse the repository at this point in the history
  48. fix go vet errors in tests

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    fdc4be2 View commit details
    Browse the repository at this point in the history
  49. update TestEncryptionStateController to match grKeysToDesiredKeys

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    69592ca View commit details
    Browse the repository at this point in the history
  50. Add support for encrytion modes

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    a9b0a25 View commit details
    Browse the repository at this point in the history
  51. hack in identity mode support

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    d053673 View commit details
    Browse the repository at this point in the history
  52. add env var based mode config

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    65ada0d View commit details
    Browse the repository at this point in the history
  53. avoid churn when turned off

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    1e98cf3 View commit details
    Browse the repository at this point in the history
  54. getEncryptionConfigAndState one line

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    967532f View commit details
    Browse the repository at this point in the history
  55. grKeysToDesiredKeys handle no tranistion state correctly

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    185a2bd View commit details
    Browse the repository at this point in the history
  56. track reasons for key creation

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    7ec53d2 View commit details
    Browse the repository at this point in the history
  57. add scary message

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    6a81b4e View commit details
    Browse the repository at this point in the history
  58. preserve continue token

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    5f11118 View commit details
    Browse the repository at this point in the history
  59. progressing during storage migration

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    25c2678 View commit details
    Browse the repository at this point in the history
  60. add two phase delete

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    785d5aa View commit details
    Browse the repository at this point in the history
  61. TODO: smarter about resources

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    2163355 View commit details
    Browse the repository at this point in the history
  62. avoid CachedSecretGetter for now

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    e2cc3dd View commit details
    Browse the repository at this point in the history
  63. explicitly verify component

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    bd44de0 View commit details
    Browse the repository at this point in the history
  64. missing the

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    a4232a4 View commit details
    Browse the repository at this point in the history
  65. non-empty message for clarity

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    66eed7d View commit details
    Browse the repository at this point in the history
  66. weekly rotation seems reasonable

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    210330b View commit details
    Browse the repository at this point in the history
  67. add e2e-encryption harness

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    fb643b0 View commit details
    Browse the repository at this point in the history
  68. address comments

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    39a52b6 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2019

  1. fix gofmt

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    742f345 View commit details
    Browse the repository at this point in the history
  2. Add encryption config to APIServer

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    df024d7 View commit details
    Browse the repository at this point in the history
  3. wire in api server and unsupported config

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    878e236 View commit details
    Browse the repository at this point in the history
  4. split unsupport config overrides in two

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    cc02c86 View commit details
    Browse the repository at this point in the history
  5. TODO: one-way force rotation

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    e14b4a6 View commit details
    Browse the repository at this point in the history
  6. simple tests

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    5da8dca View commit details
    Browse the repository at this point in the history
  7. fix WaitForKubeAPIServerClusterOperatorAvailableNotProgressingNotDegr…

    …aded
    
    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    9030413 View commit details
    Browse the repository at this point in the history
  8. advnaced tests

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    820ab78 View commit details
    Browse the repository at this point in the history
  9. test unset

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    0eee735 View commit details
    Browse the repository at this point in the history
  10. HACK: mergo bug

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    040d495 View commit details
    Browse the repository at this point in the history
  11. increase all timeouts

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    96e7134 View commit details
    Browse the repository at this point in the history
  12. DROP: temp increase base timeout since encrpytion is always enabled

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    20691df View commit details
    Browse the repository at this point in the history
  13. rebuild etcd client every time

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    81e602b View commit details
    Browse the repository at this point in the history
  14. make rotation a subtest for nicer output

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    7d3149a View commit details
    Browse the repository at this point in the history
  15. address comments

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    673685d View commit details
    Browse the repository at this point in the history
  16. filter component

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    e82b574 View commit details
    Browse the repository at this point in the history
  17. retry update on kas-o resource

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    432f232 View commit details
    Browse the repository at this point in the history
  18. faster rotation test

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    00413ce View commit details
    Browse the repository at this point in the history
  19. better error

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    00b60b1 View commit details
    Browse the repository at this point in the history
  20. limit rollouts due to read key removal

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    9f2236f View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2019

  1. TODO: test against actual keys

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    2362af5 View commit details
    Browse the repository at this point in the history
  2. try waitForEncryptionTypeLastSecretMigrated

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    cb03c0c View commit details
    Browse the repository at this point in the history
  3. tolerate migrations

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    1356522 View commit details
    Browse the repository at this point in the history
  4. better logs

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    63ac9fb View commit details
    Browse the repository at this point in the history
  5. annotation

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    25ffd34 View commit details
    Browse the repository at this point in the history
  6. TODO add stress

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    d185112 View commit details
    Browse the repository at this point in the history
  7. DROP: date logs

    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    9925b58 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c982172 View commit details
    Browse the repository at this point in the history
  9. review changes

    p0lyn0mial authored and enj committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    8752b4e View commit details
    Browse the repository at this point in the history