New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRDs are related to KAS because people ask why their resources aren't… #688
Conversation
@@ -123,6 +123,7 @@ func RunOperator(ctx *controllercmd.ControllerContext) error { | |||
"kube-apiserver", | |||
[]configv1.ObjectReference{ | |||
{Group: "operator.openshift.io", Resource: "kubeapiservers", Name: "cluster"}, | |||
{Group: "apiextensions.k8s.io", Resource: "customresourcedefinitions"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this mean without name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this mean without name?
collect all of them.
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
… present
Some bugs have come in recently and we need to have CRD manifests for SCC, CRQ, and servicemonitor.
/assign @sttts