Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes unused UsingDeprecatedAPIAppsV1Beta1 and UsingDeprecatedAPIAppsV1Beta2 alerts #705

Merged

Conversation

p0lyn0mial
Copy link
Contributor

Since apps/v1beta1 and apps/v1beta2 are disabled in Kube 1.17 we can safely remove the mentioned alerts as any attempt to create a resource will immediately return an error.

I run the following commands on a quite recent cluster:

k get --raw /apis/apps/v1beta2
k get --raw /apis/apps/v1beta1

Error from server (NotFound): the server could not find the requested resource

Client/Server version:

k version                         
Client Version: version.Info{Major:"", Minor:"", GitVersion:"v0.0.0-master+$Format:%h$", GitCommit:"$Format:%H$", GitTreeState:"", BuildDate:"1970-01-01T00:00:00Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"17+", GitVersion:"v1.17.0", GitCommit:"8a9ae19", GitTreeState:"clean", BuildDate:"2019-12-21T07:03:31Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"linux/amd64"}

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 23, 2019
@p0lyn0mial
Copy link
Contributor Author

There's also one additional alert that monitors resources (except ingresses) in extensions/v1beta1. As of 1.17 that group serves only a single resource (ingress). Given that a default cluster doesn't have any resources of that type we could disable that group too and remove the outstanding alert.

/cc @deads2k @sttts

@p0lyn0mial
Copy link
Contributor Author

/cc @lilic

@sttts
Copy link
Contributor

sttts commented Jan 8, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2020
@p0lyn0mial
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants