Fix certrotationcontroller.Run to wait for context to be canceled #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/XS
tnozicka
force-pushed
the
fix-crc-run
branch
2 times, most recently
from
5fe9451
to
853e2dd
Compare
sttts
reviewed
Jan 21, 2020
| @@ -496,4 +496,6 @@ func (c *CertRotationController) Run(ctx context.Context, workers int) { | |||
| for _, certRotator := range c.certRotators { | |||
| go certRotator.Run(ctx, workers) | |||
| } | |||
|
|
|||
| <-ctx.Done() | |||
There was a problem hiding this comment.
have you audited all consumers that they cope with a blocking Run func?
|
/lgtm I read from your PR description that you have audited all call-sites? Unhold if yes. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts, tnozicka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was printing
Shutting down CertRotationright after start.All callers wrap this in a
goand unfortunatelly don't wait for it to end, as we don't support graceful termination yet, so I don't think we need a backport./cc @deads2k @mfojtik