New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
picks kube 1.17.1 #722
picks kube 1.17.1 #722
Conversation
/assing @sttts |
"NodeDisruptionExclusion", // sig-scheduling, ccoleman | ||
"ServiceNodeExclusion", // sig-scheduling, ccoleman | ||
"SCTPSupport", // sig-network, ccallend | ||
"IPv6DualStack", // sig-network, ccoleman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this causes ci/prow/unit
to fail
--- FAIL: TestRenderCommand (0.10s)
render_test.go:295: "scenario 1 checks feature gates" reports incorrect config file, error: expected to get exactly 7 feature gates but found 6: expected=[RotateKubeletServerCertificate=true SupportPodPidsLimit=true NodeDisruptionExclusion=true ServiceNodeExclusion=true SCTPSupport=true IPv6DualStack=true LegacyNodeRoleBehavior=false] got=[RotateKubeletServerCertificate=true SupportPodPidsLimit=true NodeDisruptionExclusion=true ServiceNodeExclusion=true SCTPSupport=true LegacyNodeRoleBehavior=false]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sttts does it mean we have to enable that feature in cluster-kube-apiserver-operator
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems to be coming from
cluster-kube-apiserver-operator/bindata/bootkube/config/bootstrap-config-overrides.yaml
Line 59 in 88c1f9f
apiServerArguments: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, just update that list
/retest |
1 similar comment
/retest |
d8b5117
to
eed0dee
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
No description provided.