Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable changing bound service account token issuer from default #727

Merged
merged 1 commit into from Jan 27, 2020
Merged

Enable changing bound service account token issuer from default #727

merged 1 commit into from Jan 27, 2020

Conversation

marun
Copy link
Contributor

@marun marun commented Jan 23, 2020 •
edited

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 23, 2020
@marun marun force-pushed the bound-sa-token-issuer branch 2 times, most recently from f0cbb23 to ac254cd Compare January 23, 2020 11:51
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2020
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 23, 2020
@marun
Copy link
Contributor Author

marun commented Jan 24, 2020

/retest

@marun
Copy link
Contributor Author

marun commented Jan 24, 2020

/retest

@marun marun mentioned this pull request Jan 24, 2020
Closed
@marun
Copy link
Contributor Author

marun commented Jan 24, 2020

The e2e-aws-operator job won't be able to pass until openshift/cluster-config-operator#112 merges to ensure the test cluster is deployed with the updated Authentication.config.openshift.io CRD required by this PR.

@marun marun force-pushed the bound-sa-token-issuer branch 2 times, most recently from 4970b2f to 2176c16 Compare January 24, 2020 17:02
@marun marun changed the title WIP Enable changing bound service account token issuer from default Enable changing bound service account token issuer from default Jan 24, 2020
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 24, 2020
@marun
Copy link
Contributor Author

marun commented Jan 24, 2020

Rebased and ready for review.

@marun marun force-pushed the bound-sa-token-issuer branch 3 times, most recently from 731a716 to a739715 Compare January 24, 2020 22:15
@marun
Copy link
Contributor Author

marun commented Jan 24, 2020

/retest

1 similar comment
@marun
Copy link
Contributor Author

marun commented Jan 25, 2020

/retest

@marun
Copy link
Contributor Author

marun commented Jan 25, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2020
@marun
Copy link
Contributor Author

marun commented Jan 27, 2020

/hold cancel

Ready for review

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2020
@marun
Copy link
Contributor Author

marun commented Jan 27, 2020

Rebased

@sttts
Copy link
Contributor

sttts commented Jan 27, 2020

/retest
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2020
@openshift-merge-robot openshift-merge-robot merged commit d9ad957 into openshift:master Jan 27, 2020
deads2k added a commit to deads2k/cluster-kube-apiserver-operator that referenced this pull request Jan 27, 2020
@deads2k
Revert "Merge pull request openshift#727 from marun/bound-sa-token-is…
1a7f599 
…suer"

This reverts commit d9ad957, reversing
changes made to e40a08e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@sttts sttts Awaiting requested review from sttts

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marun @sttts @openshift-ci-robot @openshift-merge-robot