Bug 1793850: Update UsingDeprecatedAPIExtensionsV1Beta1 alert #742
Conversation
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@soltysh: This pull request references Bugzilla bug 1793850, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/S
soltysh
force-pushed
the
update_extensions_alert
branch
3 times, most recently
from
913c80b
to
5e71f13
Compare
openshift-ci-robot
added
lgtm
| group="extensions", | ||
| version="v1beta1", | ||
| }[24h] | ||
| ) > 0 | ||
| labels: | ||
| severity: warning |
There was a problem hiding this comment.
Should this be a warning still?
| expr: | | ||
| apiserver_request_count{group="extensions",version="v1beta1",resource!~"ingresses|",client!~"hyperkube/.*|cluster-policy-controller/.*"} |
There was a problem hiding this comment.
You're losing the exception in here for the velero-server which, as a piece of backup software, will scrape every api endpoint advertised in the system. Are these APIs completely removed in 4.4+, and no longer advertised?
There was a problem hiding this comment.
I'd prefer we add them if we need them. I don't see any reason to add it, yet.
|
/retest Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold Something is wrong with your manifest: |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
| @@ -110,8 +110,16 @@ spec: | |||
| rules: | |||
| - alert: UsingDeprecatedAPIExtensionsV1Beta1 | |||
| annotations: | |||
| message: A client in the cluster is using deprecated extensions/v1beta1 API that will be removed soon. | |||
| summary: "A client is using a deprecated {{"{{"}} $labels.group {{"}}"}}/{{"{{"}} $labels.version {{"}}"}} API version" | |||
There was a problem hiding this comment.
Didn't we say we don't need this alert anymore as the client can't use this extensions/v1beta1 anyways? 🤔
|
In general regarding these alerts about deprecated APIs my two cents: tl;dr:
Please ping me or @openshift/openshift-team-monitoring for any help, or advice, we should fix this soon. Thanks! (It seems we have like 3 PRs open for this, forgot which was the original one I was pinged on 🤔 ) |
|
/retest |
soltysh
force-pushed
the
update_extensions_alert
branch
from
5e71f13
to
f5b7259
Compare
|
/retest |
1 similar comment
|
/retest |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, soltysh, tnozicka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@soltysh: All pull requests linked via external trackers have merged. Bugzilla bug 1793850 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@soltysh @cblecker It is a bummer that this got merged despite the comment in #742 (comment) :-( As @lilic mentioned this will cause alert fatigue and should rather be catched in e2e tests. @lilic will submit a follow-up PR, or do you have concrete follow-up plans here? |
|
@s-urbaniak @lilic sorry, this got merged w/o my notice, fix excluding openshift elements in #762 |
/assign @tnozicka