Controller factory controllers and graceful termination fixes #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/hold
|
/lgtm |
openshift-ci-robot
added
lgtm
|
/retest |
1 similar comment
|
/retest |
openshift-ci-robot
added
the
needs-rebase
mfojtik
force-pushed
the
bump-factory-adjust
branch
from
238dbde
to
4fc21fb
Compare
openshift-ci-robot
added
size/XL
mfojtik
force-pushed
the
bump-factory-adjust
branch
from
4fc21fb
to
9b68628
Compare
openshift-ci-robot
removed
the
needs-rebase
* openshift/library-go@bfa173d6: set .sh files to be executeable * openshift/library-go@12d0d7cb: Create reusable package to manage manifests for use by CVO and oc * openshift/library-go@a6f04ac3: Set a random serial number for signing certificate templates * openshift/library-go@4657d563: controller: add manager and wire graceful termination into leader election * openshift/library-go@9a403ca7: resourcesynccontroller: migrate to controller factory
mfojtik
force-pushed
the
bump-factory-adjust
branch
from
9b68628
to
a51bde2
Compare
mfojtik
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up work to adjust the operator controller to follow the controller factory pattern set in library-go.
/hold
Until 4.5 open.