Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1801154: manifests/: Throw away unused high cardinality apiserver duration buckets #752

Merged

Conversation

lilic
Copy link
Contributor

@lilic lilic commented Feb 5, 2020

This shouldn't have any effect on our alerts or dashboards as the buckets are cumulative and for those purposes the remaining buckets should be sufficient.

Note: this change was made in "upstream" kube-promethues repo, see background for this prometheus-operator/kube-prometheus#387

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 5, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2020
@lilic
Copy link
Contributor Author

lilic commented Feb 10, 2020

/assign @tnozicka PTAL, thanks!

@lilic lilic changed the title manifests/: Throw away unused high cardinality apiserver duration buckets Bug 1801154: manifests/: Throw away unused high cardinality apiserver duration buckets Feb 10, 2020
@openshift-ci-robot
Copy link

@lilic: This pull request references Bugzilla bug 1801154, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1801154: manifests/: Throw away unused high cardinality apiserver duration buckets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 10, 2020
@lilic
Copy link
Contributor Author

lilic commented Feb 10, 2020

/retest

doesn't seem to be related.

@mfojtik
Copy link
Member

mfojtik commented Feb 10, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiliC, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit dcfcba9 into openshift:master Feb 10, 2020
@openshift-ci-robot
Copy link

@lilic: All pull requests linked via external trackers have merged. Bugzilla bug 1801154 has been moved to the MODIFIED state.

In response to this:

Bug 1801154: manifests/: Throw away unused high cardinality apiserver duration buckets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants