New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bindata: preselect container name for oc #753
bindata: preselect container name for oc #753
Conversation
This is just cosmetic change and this don't need a bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -8,6 +8,7 @@ metadata: | |||
openshift.io/component: "api" | |||
annotations: | |||
openshift.io/run-level: "0" | |||
kubectl.kubernetes.io/default-logs-container: kube-apiserver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty nice!
/refresh |
This is cosmetic change to kube-apiserver pod that preselect kube-apiserver container when calling
kubectl logs
. Users don't have to specify the container name anymore and api server container will be used by default.It require
oc
from master, there is no change in behavior with olderoc
.