Bug 1802247: Check operator readiness before each bound token controller test #763
Conversation
openshift-ci-robot
added
the
size/XS
Previously operator readiness was only checked at the start of the set of bound token controller tests. This introduced the likelyhood of the configmap deletion test rollout of a new apiserver pod revision and without the subsequent operand secret deletion test knowing to wait rollout completion.
marun
force-pushed
the
increase-test-timeout
branch
from
06c5554
to
b2cfc7d
Compare
marun
changed the title
|
Updated to check for operator readiness for each bound token controller test rather than before any are executed. I suspect that not checking operator readiness prior to deletion of the operator signing secret was the reason the test was flaking. |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marun, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test all |
marun
changed the title
|
@marun: This pull request references Bugzilla bug 1802247, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@marun: This pull request references Bugzilla bug 1802247, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@marun: All pull requests linked via external trackers have merged. Bugzilla bug 1802247 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Previously operator readiness was only checked at the start of the set of bound token controller tests. This introduced the possibility of the configmap deletion test triggering rollout of a new apiserver pod revision that the subsequent operand secret deletion test wouldn't wait for before starting.