New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug 1805421: skip using bootstrap etcd #772
bug 1805421: skip using bootstrap etcd #772
Conversation
2374571
to
9c0ca22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, sanchezl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@deads2k: This pull request references Bugzilla bug 1805421, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@deads2k: This pull request references Bugzilla bug 1805421, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/cherrypick release-4.4 |
@deads2k: new pull request created: #774 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
To avoid errors in the bootstrap kube-apiserver, we want to avoid removing the bootstrap etcd member until after the bootstrapping is complete. In addition, today we're using an etcd endpoint (etcd-bootstrap) which isn't valid most of the time. This stops using that.
This could produce a short-term situation where the etcd health check fails until the in-cluster etcd is present. If this becomes a practical problem, we can add a check that pings all the etcds to see if at least one is up before proceeding, but I wouldnt' worry about it until it's actually a problem.