Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1810133: connect to etcd using IPs #787

Merged
merged 2 commits into from Mar 4, 2020
Merged

Bug 1810133: connect to etcd using IPs #787

merged 2 commits into from Mar 4, 2020

Conversation

sanchezl
Copy link
Contributor

@sanchezl sanchezl commented Mar 4, 2020 •
edited

  • Use IPs instead of DNS names to generate storage URLs.
  • Always add local host storage URLs.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 4, 2020
@sanchezl sanchezl mentioned this pull request Mar 4, 2020
Merged
@sanchezl sanchezl changed the title switch to etcd-host-2 Bug 1810133: connect to etcd using IPs Mar 4, 2020
@openshift-ci-robot
Copy link

@sanchezl: This pull request references Bugzilla bug 1810133, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1810133: connect to etcd using IPs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 4, 2020
@openshift-ci-robot
Copy link

@sanchezl: This pull request references Bugzilla bug 1810133, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1810133: connect to etcd using IPs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor

deads2k commented Mar 4, 2020

/lgtm

@sanchezl how did you break verify-deps?

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 4, 2020
@deads2k
Copy link
Contributor

deads2k commented Mar 4, 2020

/retest

@sanchezl
go mod vendor && go mod tidy
e5fdbde 
cleanup unused deps
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 4, 2020
@deads2k
Copy link
Contributor

deads2k commented Mar 4, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor

deads2k commented Mar 4, 2020

/retest

@sanchezl sanchezl mentioned this pull request Mar 4, 2020
Closed
15 tasks
@openshift-merge-robot openshift-merge-robot merged commit 41f93ff into openshift:master Mar 4, 2020
@openshift-cherrypick-robot
Copy link

@hexfusion: cannot checkout release-4,4: error checking out release-4,4: exit status 1. output: error: pathspec 'release-4,4' did not match any file(s) known to git.

In response to this:

/cherry-pick release-4,4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Contributor

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

@hexfusion: new pull request created: #789

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 6, 2020
Closed
@sanchezl sanchezl mentioned this pull request Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@hexfusion hexfusion Awaiting requested review from hexfusion

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sanchezl @openshift-ci-robot @deads2k @openshift-cherrypick-robot @hexfusion @openshift-merge-robot