Bug 1810181: Components using globs in Dockerfile COPY commands may break on OCP 4 #802
Conversation
p0lyn0mial
changed the title
|
@p0lyn0mial: This pull request references Bugzilla bug 1810181, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
I was just about to open a PR with https://github.com/stlaz/cluster-kube-apiserver-operator/tree/wildcard_cp_remove, WDYT? |
|
/test e2e-aws |
| COPY --from=builder /go/src/github.com/openshift/cluster-kube-apiserver-operator/cluster-kube-apiserver-operator /usr/bin/ | ||
| COPY manifests/*.yaml /manifests/ | ||
| COPY manifests/image-references /manifests/ | ||
| COPY manifests /manifests |
There was a problem hiding this comment.
do we know that folder structure does not matter?
There was a problem hiding this comment.
The content is exactly the same. The directory contains a bunch of yaml files and image-references file. Previously they were copied in two separate steps COPY manifests/*.yaml /manifests/ and COPY manifests/image-references /manifests/. Now only with one command COPY manifests /manifests
There was a problem hiding this comment.
let's see what happens when it is incorrect - I suspect the build failing.
There was a problem hiding this comment.
All e2e tests except e2e-aws-upgrade failed on the bootstrap step.
I suspect e2e-aws-upgrade passed because the previous version applied the manifests.
There was a problem hiding this comment.
additionally, checking the image layer on the local disk gives the correct directory structure.
docker build
...
Step 11/13 : COPY manifests /manifests
---> 880677ddc878
I think that UpperDir contains changes made by that container
docker inspect 880677ddc878
...
"UpperDir":"/var/lib/docker/overlay2/5b82326af7a839d45bb2e25a3cf0903e92493f395630d39fc4835efa955916a3/diff"
Listing the content gives
ls 5b82326af7a839d45bb2e25a3cf0903e92493f395630d39fc4835efa955916a3/diff/manifests/
0000_20_kube-apiserver-operator_00_namespace.yaml 0000_20_kube-apiserver-operator_00_scc-hostnetwork.yaml 0000_20_kube-apiserver-operator_01_operator.cr.yaml 0000_20_kube-apiserver-operator_05_serviceaccount.yaml 0000_90_kube-apiserver-operator_02_prometheusrolebinding.yaml
0000_20_kube-apiserver-operator_00_scc-anyuid.yaml 0000_20_kube-apiserver-operator_00_scc-nonroot.yaml 0000_20_kube-apiserver-operator_02_service.yaml 0000_20_kube-apiserver-operator_06_deployment.yaml 0000_90_kube-apiserver-operator_03_servicemonitor.yaml
0000_20_kube-apiserver-operator_00_scc-hostaccess.yaml 0000_20_kube-apiserver-operator_00_scc-privileged.yaml 0000_20_kube-apiserver-operator_03_configmap.yaml 0000_20_kube-apiserver-operator_07_clusteroperator.yaml 0000_90_kube-apiserver-operator_04_servicemonitor-apiserver.yaml
0000_20_kube-apiserver-operator_00_scc-hostmount-anyuid.yaml 0000_20_kube-apiserver-operator_00_scc-restricted.yaml 0000_20_kube-apiserver-operator_04_clusterrolebinding.yaml 0000_90_kube-apiserver-operator_01_prometheusrole.yaml image-references
There was a problem hiding this comment.
copying only a single file COPY manifests/image-references /manifests/ gives me
ls ab9dc871721dccc831953c924029252ed8156771251e36fbb129fe0cc20069eb/diff/manifests/
image-references
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
p0lyn0mial
force-pushed
the
glob-docker-fix
branch
from
62a141e
to
4375697
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@p0lyn0mial: Some pull requests linked via external trackers have merged: openshift/cluster-kube-apiserver-operator#802. The following pull requests linked via external trackers have not merged:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.4 |
|
@p0lyn0mial: new pull request created: #808 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.