Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1819246: Set service account issuer to internal dns name of kube apiserver #809

Merged
merged 2 commits into from Apr 9, 2020
Merged

Bug 1819246: Set service account issuer to internal dns name of kube apiserver #809

merged 2 commits into from Apr 9, 2020

Conversation

marun
Copy link
Contributor

@marun marun commented Apr 2, 2020 •
edited

The default issuer for bound service account tokens is updated to point to the internal dns name of the kube apiserver to ensure compatibility with the ServiceAccountIssuerDiscovery feature [1] added in kube 1.18. This fix is intended to be backported to 4.4 (the release that added support for bound service account otkens) before GA to ensure that the default will be compatible from introduction with the discovery feature without having to update the issuer (which would involve reissuing all existing bound tokens).

1: https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#service-account-issuer-discovery

Related change: openshift/api#617

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 2, 2020
@openshift-ci-robot
Copy link

@marun: This pull request references Bugzilla bug 1819246, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1819246: Set service account issuer to internal dns name of kube apiserver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marun
Copy link
Contributor Author

marun commented Apr 2, 2020

/cc @sttts @stlaz

@marun marun mentioned this pull request Apr 2, 2020
Merged
@openshift-ci-robot
Copy link

@marun: This pull request references Bugzilla bug 1819246, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1819246: Set service account issuer to internal dns name of kube apiserver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marun
Copy link
Contributor Author

marun commented Apr 2, 2020

/retest

stlaz
stlaz suggested changes Apr 7, 2020
View reviewed changes
test/e2e/bound_sa_token_test.go Outdated
@@ -237,7 +238,7 @@ func TestChangeServiceAccountIssuer(t *testing.T) {
// Wait for operator readiness
test.WaitForKubeAPIServerClusterOperatorAvailableNotProgressingNotDegraded(t, configClient)

defaultIssuer := "auth.openshift.io"
defaultIssuer := "https://apiserver.openshift-kube-apiserver.svc"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for the SA OIDC discovery to work, this must be reachable from the outside of the cluster

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
see openshift/api#617 (comment) first, since this PR somewhat depends on the api, I think we should add the hold to this PR until the discussion there is resolved

Copy link
Member

@stlaz stlaz Apr 7, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the discussion mentioned above, set to https://kubernetes.default.svc please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, PTAL.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2020
@marun
Set service account issuer to internal dns name of kube apiserver
62f56b0 
The default issuer for bound service account tokensd is updated to
point to the internal dns name of the kube apiserver to ensure
compatibility with the ServiceAccountIssuerDiscovery feature added in
kube 1.18.
@marun
make update
0c34ea2
@marun marun force-pushed the fix-bound-sa-token-issuer branch from 365e026 to 0c34ea2 Compare April 7, 2020 17:43
@marun
Copy link
Contributor Author

marun commented Apr 7, 2020

Also updated the enhancement for consistency: openshift/enhancements#281

@stlaz
Copy link
Member

stlaz commented Apr 7, 2020

/hold cancel
/lgtm

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2020
@marun
Copy link
Contributor Author

marun commented Apr 7, 2020

/retest

@sttts
Copy link
Contributor

sttts commented Apr 8, 2020

/approve
/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, stlaz, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2020
@marun
Copy link
Contributor Author

marun commented Apr 8, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

@marun: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit dfe5210 into openshift:master Apr 9, 2020
@openshift-ci-robot
Copy link

@marun: All pull requests linked via external trackers have merged: openshift/cluster-kube-apiserver-operator#809, openshift/api#617. Bugzilla bug 1819246 has been moved to the MODIFIED state.

In response to this:

Bug 1819246: Set service account issuer to internal dns name of kube apiserver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 9, 2020
Closed
@openshift-cherrypick-robot
Copy link

@marun: new pull request created: #823

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlaz stlaz stlaz requested changes

@sttts sttts Awaiting requested review from sttts

@mfojtik mfojtik Awaiting requested review from mfojtik

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@stlaz stlaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@marun @openshift-ci-robot @stlaz @sttts @openshift-cherrypick-robot @openshift-bot @openshift-merge-robot