Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1838122: add admission webhooks to must-gather for kas-o #865

Merged
merged 1 commit into from May 20, 2020

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented May 20, 2020

We need this information to understand certain bootstrapping loops caused by overly broad admission webhook configuration that prevent restarts.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2020
@mfojtik
Copy link
Member

mfojtik commented May 20, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfojtik mfojtik changed the title add admission webhooks to must-gather for kas-o Bug 1838122: add admission webhooks to must-gather for kas-o May 20, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label May 20, 2020
@openshift-ci-robot
Copy link

@deads2k: This pull request references Bugzilla bug 1838122, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1838122: add admission webhooks to must-gather for kas-o

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 20, 2020
@mfojtik
Copy link
Member

mfojtik commented May 20, 2020

/cherrypick release-4.4

@deads2k we want in ^ right?

@openshift-cherrypick-robot

@mfojtik: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.4

@deads2k we want in ^ right?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Member

mfojtik commented May 20, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels May 20, 2020
@openshift-ci-robot
Copy link

@mfojtik: This pull request references Bugzilla bug 1838122, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 20d9518 into openshift:master May 20, 2020
@openshift-ci-robot
Copy link

@deads2k: All pull requests linked via external trackers have merged: openshift/cluster-kube-apiserver-operator#865. Bugzilla bug 1838122 has been moved to the MODIFIED state.

In response to this:

Bug 1838122: add admission webhooks to must-gather for kas-o

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mfojtik: #865 failed to apply on top of branch "release-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	manifests/0000_20_kube-apiserver-operator_07_clusteroperator.yaml
M	pkg/operator/starter.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/starter.go
Auto-merging manifests/0000_20_kube-apiserver-operator_07_clusteroperator.yaml
CONFLICT (content): Merge conflict in manifests/0000_20_kube-apiserver-operator_07_clusteroperator.yaml
Patch failed at 0001 add admission webhooks to must-gather for kas-o

In response to this:

/cherrypick release-4.4

@deads2k we want in ^ right?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants