Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1861431: LatencySensitive feature gate allows upgrades #920

Merged
merged 1 commit into from Jul 30, 2020
Merged

Bug 1861431: LatencySensitive feature gate allows upgrades #920

merged 1 commit into from Jul 30, 2020

Conversation

MarSik
Copy link
Contributor

@MarSik MarSik commented Jul 30, 2020

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jul 30, 2020
@openshift-ci-robot
Copy link

@MarSik: This pull request references Bugzilla bug 1861431, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1861431: LatencySensitive feature gate allows upgrades

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 30, 2020
@MarSik
Copy link
Contributor Author

MarSik commented Jul 30, 2020

/assign vpickard

@MarSik
Copy link
Contributor Author

MarSik commented Jul 30, 2020

/assign rphillips

@MarSik
Copy link
Contributor Author

MarSik commented Jul 30, 2020

/assign @sttts

@sttts
Copy link
Contributor

sttts commented Jul 30, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 30, 2020
cynepco3hahue
cynepco3hahue reviewed Jul 30, 2020
View reviewed changes
pkg/operator/featureupgradablecontroller/feature_upgradeable_controller.go
@@ -15,7 +15,7 @@ import (
)

var (
featureGatesAllowingUpgrade = sets.NewString("")
featureGatesAllowingUpgrade = sets.NewString("", string(configv1.LatencySensitive))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change it to featureGatesAllowingUpgrade = sets.NewString(string(configv1.LatencySensitive))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that actually fails one of the tests (I tried). The empty string seems to represent a situation with no feature gates.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had such feelings, thanks for the clarification.

@MarSik
Copy link
Contributor Author

MarSik commented Jul 30, 2020

/cherry-pick 4.5

@openshift-cherrypick-robot
Copy link

@MarSik: once the present PR merges, I will cherry-pick it on top of 4.5 in a new PR and assign it to you.

In response to this:

/cherry-pick 4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MarSik
Copy link
Contributor Author

MarSik commented Jul 30, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 30, 2020
@openshift-ci-robot
Copy link

@MarSik: This pull request references Bugzilla bug 1861431, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MarSik
Copy link
Contributor Author

MarSik commented Jul 30, 2020

/retest

vpickard
vpickard reviewed Jul 30, 2020
View reviewed changes
Copy link

@vpickard vpickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These code changes will allow the upgrade to move forward. Has any testing been done with these changes to ensure that pods can still spin up after the upgrade, with the LatencySensitive feature enabled?

vpickard
vpickard reviewed Jul 30, 2020
View reviewed changes
Copy link

@vpickard vpickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Left earlier comment that we need to do upgraded testing with this feature enabled. Thanks for the fix!

@vpickard
Copy link

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, sttts, vpickard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 19c2ecc into openshift:master Jul 30, 2020
@openshift-ci-robot
Copy link

@MarSik: All pull requests linked via external trackers have merged: openshift/cluster-kube-apiserver-operator#920. Bugzilla bug 1861431 has been moved to the MODIFIED state.

In response to this:

Bug 1861431: LatencySensitive feature gate allows upgrades

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@MarSik: cannot checkout 4.5: error checking out 4.5: exit status 1. output: error: pathspec '4.5' did not match any file(s) known to git

In response to this:

/cherry-pick 4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MarSik
Copy link
Contributor Author

MarSik commented Jul 30, 2020

/cherry-pick release-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 30, 2020
Merged
@openshift-cherrypick-robot
Copy link

@MarSik: new pull request created: #921

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MarSik
Copy link
Contributor Author

MarSik commented Jul 30, 2020

/bugzilla cc-qa

@openshift-ci-robot
Copy link

@MarSik: Bugzilla bug 1861431 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cynepco3hahue cynepco3hahue cynepco3hahue left review comments

@vpickard vpickard vpickard left review comments

@deads2k deads2k Awaiting requested review from deads2k

@sttts sttts Awaiting requested review from sttts

Assignees

@rphillips rphillips

@sttts sttts

@vpickard vpickard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@MarSik @openshift-ci-robot @sttts @openshift-cherrypick-robot @vpickard @cynepco3hahue @rphillips @openshift-merge-robot