Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1878289: connectivity check events have ambiguous related object #934

Conversation

sanchezl
Copy link
Contributor

No description provided.

@sanchezl sanchezl force-pushed the check-endpoints-reporting-component branch from 1729ffb to 41e4404 Compare August 18, 2020 14:59
@sanchezl sanchezl force-pushed the check-endpoints-reporting-component branch from 41e4404 to 131a169 Compare September 11, 2020 06:26
@sanchezl sanchezl changed the title check-endpoints: add node name as reporting component of events check-endpoints: use node as involved object Sep 11, 2020
apiGroups:
- ""
verbs:
- create
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get, list, watch, create, update, patch

roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: system:node-reader
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to where this is defined? I don't recognize it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name:         system:node-reader
Labels:       kubernetes.io/bootstrapping=rbac-defaults
Annotations:  rbac.authorization.kubernetes.io/autoupdate: true
PolicyRule:
  Resources      Non-Resource URLs  Resource Names  Verbs
  ---------      -----------------  --------------  -----
  nodes/stats    []                 []              [create get]
  nodes          []                 []              [get list watch]
  nodes/metrics  []                 []              [get]
  nodes/spec     []                 []              [get]

I found this: https://github.com/openshift/openshift-apiserver/blob/ed260ac7ae860d493187963ce23efabb36a2884f/pkg/cmd/server/bootstrappolicy/policy.go#L411-L434

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a second clusterrole if need be

@deads2k
Copy link
Contributor

deads2k commented Sep 11, 2020

/lgtm
/hold

looks fine. needs to be green though and fix the role. release hold and reapply when ready.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2020
@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 11, 2020
@sanchezl
Copy link
Contributor Author

/retest

@sanchezl sanchezl force-pushed the check-endpoints-reporting-component branch from 131a169 to 094ba9a Compare September 11, 2020 14:31
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
@sanchezl
Copy link
Contributor Author

/test k8s-e2e-gcp
/test e2e-aws-operator

@sanchezl sanchezl changed the title check-endpoints: use node as involved object Bug 1878289: connectivity check events have ambiguous related object Sep 11, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 11, 2020
@openshift-ci-robot
Copy link

@sanchezl: This pull request references Bugzilla bug 1878289, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1878289: connectivity check events have ambiguous related object

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 11, 2020
@sanchezl
Copy link
Contributor Author

/test e2e-aws-operator

@sanchezl
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2020
@sanchezl sanchezl force-pushed the check-endpoints-reporting-component branch from 094ba9a to e792c06 Compare September 14, 2020 19:02
@sanchezl
Copy link
Contributor Author

/test e2e-aws-serial
/test e2e-aws

@sanchezl
Copy link
Contributor Author

/test k8s-e2e-gcp

@deads2k
Copy link
Contributor

deads2k commented Sep 15, 2020

/lgtm

@deads2k deads2k closed this Sep 15, 2020
@deads2k deads2k reopened this Sep 15, 2020
@openshift-ci-robot
Copy link

@sanchezl: This pull request references Bugzilla bug 1878289. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 1878289: connectivity check events have ambiguous related object

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@sanchezl: This pull request references Bugzilla bug 1878289, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1878289: connectivity check events have ambiguous related object

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor

deads2k commented Sep 15, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 94905e2 into openshift:master Sep 15, 2020
@openshift-ci-robot
Copy link

@sanchezl: All pull requests linked via external trackers have merged:

Bugzilla bug 1878289 has been moved to the MODIFIED state.

In response to this:

Bug 1878289: connectivity check events have ambiguous related object

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants