Specify "bindNetwork: tcp" so controller manager will work on IPv6 single-stack #320
Conversation
openshift-ci-robot
added
the
size/XS
|
/lgtm Thank you! |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, russellb, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/cherry-pick release-4.3 |
|
@soltysh: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@soltysh: new pull request created: #327 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If you say
net.Listen("tcp", "0.0.0.0:10357"), golang will actually create a dual-stack IPv4/IPv6 listening socket. But for historical reasons (having to do with bad IPv6 compat in older kube I think), we default to passing"tcp4"(the default value ofconfigv1.ServingInfo.BindNetwork) instead of"tcp", forcing IPv4-only.There is no reason these days for servers on the pod network to enforce IPv4-only, so this overrides the default for kube-controller-manager.
This will need to be backported to 4.3.
(based on an earlier patch from @russellb )