Bug 1806640: fix potential errors in Prometheus alerts #414
Conversation
openshift-ci-robot
added
the
bugzilla/severity-low
|
@simonpasquier: This pull request references Bugzilla bug 1806640, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
manifests/0000_90_kube-controller-manager-operator_05_alert-pdb.yaml
Outdated
Show resolved
Hide resolved
openshift-ci-robot
added
the
approved
There is no need to use the 'on' keyword to compare kube_poddisruptionbudget_status_expected_pods and kube_poddisruptionbudget_status_desired_healthy because both series have the same label set. In addition when there are 2 instances of kube-state-metrics running, it triggers evaluation errors in Prometheus. To ensure that the expression returns one item per (namespace, poddisruptionbudget) tuple, it is wrapped by the 'max' aggregation operator. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
|
/retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, simonpasquier, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@simonpasquier: All pull requests linked via external trackers have merged: openshift/cluster-kube-controller-manager-operator#414. Bugzilla bug 1806640 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There is no need to use the 'on' keyword to compare
kube_poddisruptionbudget_status_expected_pods and
kube_poddisruptionbudget_status_desired_healthy because both series have
the same label set. In addition when there are 2 instances of
kube-state-metrics running, it triggers evaluation errors in Prometheus.
To ensure that the expression returns one item per (namespace,
poddisruptionbudget) tuple, it is wrapped by the 'max' aggregation
operator.