Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.4] Bug 1876484: static-pod-installer: remove deadlock by recreating inst… #457

Merged
merged 1 commit into from Oct 1, 2020
Merged

[release-4.4] Bug 1876484: static-pod-installer: remove deadlock by recreating inst… #457

merged 1 commit into from Oct 1, 2020

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Sep 23, 2020

…allers that disappear

Picks openshift/library-go#881

/assign @sttts @sdodson

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 23, 2020
@openshift-ci-robot
Copy link

@soltysh: This pull request references Bugzilla bug 1876484, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.z) matches configured target release for branch (4.4.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1874597 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1874597 targets the "4.5.z" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents

In response to this:

Bug 1876484: static-pod-installer: remove deadlock by recreating inst…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 23, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2020
@soltysh soltysh changed the title Bug 1876484: static-pod-installer: remove deadlock by recreating inst… [release-4.4] Bug 1876484: static-pod-installer: remove deadlock by recreating inst… Sep 23, 2020
@soltysh
Copy link
Member Author

soltysh commented Sep 23, 2020

/retest

@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 26, 2020
Merged
@markmc markmc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 28, 2020
@soltysh
Copy link
Member Author

soltysh commented Sep 28, 2020

/retest

@sttts
Copy link
Contributor

sttts commented Sep 28, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmc markmc removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 28, 2020
@ashcrow ashcrow added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 1, 2020
@openshift-merge-robot openshift-merge-robot merged commit 2436db0 into openshift:release-4.4 Oct 1, 2020
@openshift-ci-robot
Copy link

@soltysh: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1876484 has not been moved to the MODIFIED state.

In response to this:

[release-4.4] Bug 1876484: static-pod-installer: remove deadlock by recreating inst…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 1, 2020
Merged
@soltysh soltysh deleted the bug1876484 branch October 15, 2020 08:37
@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@sttts sttts Awaiting requested review from sttts

Assignees

@sdodson sdodson

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@soltysh @openshift-ci-robot @sttts @markmc @ashcrow @sdodson @openshift-merge-robot