Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1915500: support custom CA bundle for AWS C2S #494

Merged
merged 1 commit into from Jan 16, 2021
Merged

Bug 1915500: support custom CA bundle for AWS C2S #494

merged 1 commit into from Jan 16, 2021

Conversation

staebler
Copy link
Contributor

Communication with the AWS API in the C2S Secret region requires a custom CA bundle. This bundle is stored in the "ca-bundle.pem" entry in the cloud-config. The AWS_CA_BUNDLE environment variable informs the AWS SDK to use a custom CA bundle and to specify the location of the bundle.

@staebler
support custom CA bundle for AWS C2S
3ce7fac 
Communication with the AWS API in the C2S Secret region requires a
custom CA bundle. This bundle is stored in the "ca-bundle.pem" entry
in the cloud-config. The AWS_CA_BUNDLE environment variable informs
the AWS SDK to use a custom CA bundle and to specify the location of
the bundle.
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2021
@staebler staebler changed the title WIP: support custom CA bundle for AWS C2S Bug 1915500: WIP: support custom CA bundle for AWS C2S Jan 12, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 12, 2021
@openshift-ci-robot
Copy link

@staebler: This pull request references Bugzilla bug 1915500, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1915500: WIP: support custom CA bundle for AWS C2S

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@staebler staebler changed the title Bug 1915500: WIP: support custom CA bundle for AWS C2S Bug 1915500: support custom CA bundle for AWS C2S Jan 12, 2021
@staebler
Copy link
Contributor Author

@deads2k This seems really ugly to me to inject cloud-specific logic into the pod yaml. Is there a better way to do this?

@mfojtik
Copy link
Member

mfojtik commented Jan 15, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2021
@marun
Copy link
Contributor

marun commented Jan 15, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d9b1a9e into openshift:master Jan 16, 2021
@openshift-ci-robot
Copy link

@staebler: All pull requests linked via external trackers have merged:

Bugzilla bug 1915500 has been moved to the MODIFIED state.

In response to this:

Bug 1915500: support custom CA bundle for AWS C2S

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@sttts sttts Awaiting requested review from sttts

Assignees

@mfojtik mfojtik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@staebler @openshift-ci-robot @mfojtik @marun @openshift-bot @openshift-merge-robot