update cluster-policy-controller configuration #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
atiratree
force-pushed
the
pass-ns-to-cluster-policy-controller
branch
from
2c6e4a2
to
ffcf6b7
Compare
atiratree
changed the title
|
/assign @soltysh |
atiratree
commented
Jul 8, 2021
bindata/v4.1.0/kube-controller-manager/cluster-policy-controller-role.yaml
Outdated
Show resolved
Hide resolved
atiratree
force-pushed
the
pass-ns-to-cluster-policy-controller
branch
2 times, most recently
from
c1ec02b
to
a13ad84
Compare
|
@soltysh I removed the additional RBAC and mirrored changes to the bindata/bootkube |
- pass pod metadata and kubeconfig to the controller - add new role for getting pods (required by event recorder)
atiratree
force-pushed
the
pass-ns-to-cluster-policy-controller
branch
from
a13ad84
to
b0a0a38
Compare
soltysh
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
/lgtm
/approve
/hold
for openshift/cluster-policy-controller#67
openshift-ci
bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atiratree, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is required for cluster-policy-controller refactoring: openshift/cluster-policy-controller#65