[4.12] OCPBUGS-6789: honor feature gates during bootstrapping #695
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@stlaz: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
jira/valid-bug
|
@stlaz: This pull request references Jira Issue OCPBUGS-6789, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. |
stlaz
changed the title
|
@stlaz: No Bugzilla bug is referenced in the title of this pull request. Retaining the bugzilla/valid-bug label as it was manually added. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve for lgtm |
openshift-ci
bot
added
the
approved
| @@ -4,3 +4,5 @@ servingInfo: | |||
| clientCA: /etc/kubernetes/secrets/kube-control-plane-ca-bundle.crt | |||
| certFile: /etc/kubernetes/secrets/kube-control-plane-kube-controller-manager-client.crt | |||
| keyFile: /etc/kubernetes/secrets/kube-control-plane-kube-controller-manager-client.key | |||
| featureGates: {{range .FeatureGates}} | |||
| - {{.}}{{end}} | |||
There was a problem hiding this comment.
Do we want to have a proper file ending? Or do we ignore it on a backport?
| @@ -25,3 +25,5 @@ extendedArguments: | |||
| - "" | |||
| pv-recycler-pod-template-filepath-hostpath: | |||
| - "" | |||
| feature-gates: {{range .FeatureGates}} | |||
| - {{.}}{{end}} | |||
There was a problem hiding this comment.
Do we want to have a proper file ending? Or do we ignore it on a backport?
stlaz
force-pushed
the
deads2k_featuresets_412_featuregates
branch
from
deb37d1
to
0a5d2bd
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, ibihim, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label backport-risk-assessed |
|
@stlaz: Can not set label backport-risk-assessed: Must be member in one of these teams: [] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@stlaz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
mfojtik
added
the
backport-risk-assessed
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@stlaz: Jira Issue OCPBUGS-6789: Some pull requests linked via external trackers have merged:
The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-6789 has not been moved to the MODIFIED state. |
backport of #686
/cc @deads2k @ibihim