Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-24215: Annotate rotated certificates #769

Merged
merged 3 commits into from Nov 29, 2023
Merged

OCPBUGS-24215: Annotate rotated certificates #769

merged 3 commits into from Nov 29, 2023

Conversation

vrutkovs
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 22, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

3 similar comments
@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

@vrutkovs vrutkovs marked this pull request as ready for review November 29, 2023 09:26
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2023
@deads2k
Copy link
Contributor

deads2k commented Nov 29, 2023

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@vrutkovs vrutkovs changed the title Annotate rotated certificates OCPBUGS-24215: Annotate rotated certificates Nov 29, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 29, 2023
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-24215, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

@vrutkovs: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 71d8513 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0026794 into openshift:master Nov 29, 2023
9 of 10 checks passed
@openshift-ci-robot
Copy link

@vrutkovs: Jira Issue OCPBUGS-24215: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-24215 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-controller-manager-operator-container-v4.15.0-202311292108.p0.g0026794.assembly.stream for distgit ose-cluster-kube-controller-manager-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-12-02-123536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@atiratree atiratree Awaiting requested review from atiratree

@mfojtik mfojtik Awaiting requested review from mfojtik

@zhouying7780 zhouying7780 Awaiting requested review from zhouying7780

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vrutkovs @deads2k @openshift-ci-robot @openshift-bot @openshift-merge-robot