add liveness and readiness probes to static pod #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
openshift-ci-robot
added
the
approved
deads2k
reviewed
Nov 9, 2018
deads2k
reviewed
Nov 9, 2018
|
/hold Waiting for 1.12.2 rebase and controller manager that have secure healthz endpoint. |
openshift-ci-robot
added
the
do-not-merge/hold
mfojtik
force-pushed
the
add-probes
branch
2 times, most recently
from
c6f88cc
to
4b3e594
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
mfojtik
force-pushed
the
add-probes
branch
3 times, most recently
from
789dae8
to
9062404
Compare
openshift-ci-robot
added
size/M
mfojtik
commented
Jan 30, 2019
| @@ -9,8 +9,8 @@ extendedArguments: | |||
| - "/etc/kubernetes/secrets/kube-ca.crt" | |||
| cluster-signing-key-file: | |||
| - "/etc/kubernetes/secrets/kube-ca.key" | |||
| port: | |||
| - "0" | |||
mfojtik
commented
Jan 30, 2019
| scheme: HTTPS | ||
| port: 10257 | ||
| path: healthz | ||
| initialDelaySeconds: 45 |
There was a problem hiding this comment.
copied from kube-apiserver, i'm up for suggestion on better numbers (i think we need some initial delay till the controller manager apiserver boots up)
sttts
reviewed
Jan 30, 2019
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@deads2k @sttts lets discuss the probes under this PR...
Right now, we have wrong port on the service and I don't think so we serving the healthz or metrics security from controller manager. Also the
10252seems odd and we need to decide if we keep it or just move to something else? (8444 before).