Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-21846: bump(library-go): update last revision only when a revision is completely rendered #773

Conversation

ingvagabund
Copy link
Member

Validating for openshift/library-go#1641

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 9, 2023
@openshift-ci-robot
Copy link

@ingvagabund: This pull request references Jira Issue OCPBUGS-21846, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Validating for openshift/library-go#1641

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Dec 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2023
@ingvagabund
Copy link
Member Author

/hold
until openshift/library-go#1641 merges

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2023
@ingvagabund
Copy link
Member Author

/retest-required

@ingvagabund
Copy link
Member Author

From https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-kube-controller-manager-operator/773/pull-ci-openshift-cluster-kube-controller-manager-operator-master-e2e-aws-operator/1733612474223038464/artifacts/e2e-aws-operator/gather-extra/artifacts/pods/openshift-kube-controller-manager-operator_kube-controller-manager-operator-5b4f88948f-m7pcs_kube-controller-manager-operator.log:

I1209 22:35:53.967298       1 event.go:298] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-kube-controller-manager-operator", Name:"kube-controller-manager-operator", UID:"7d133f2c-2b17-448b-a2a3-e83f399cac1b", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'SecretCreated' Created Secret/localhost-recovery-client-token-3 -n openshift-kube-controller-manager because it was missing
I1209 22:35:54.766725       1 event.go:298] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-kube-controller-manager-operator", Name:"kube-controller-manager-operator", UID:"7d133f2c-2b17-448b-a2a3-e83f399cac1b", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'RevisionTriggered' new revision 3 triggered by "required configmap/serviceaccount-ca has changed"
I1209 22:35:54.776287       1 event.go:298] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-kube-controller-manager-operator", Name:"kube-controller-manager-operator", UID:"7d133f2c-2b17-448b-a2a3-e83f399cac1b", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'RevisionCreate' Revision 3 created because required configmap/serviceaccount-ca has changed
I1209 22:35:54.777748       1 event.go:298] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-kube-controller-manager-operator", Name:"kube-controller-manager-operator", UID:"7d133f2c-2b17-448b-a2a3-e83f399cac1b", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'StartingNewRevision' new revision 3 triggered by "required configmap/serviceaccount-ca has changed"
I1209 22:35:55.966614       1 revision_controller.go:246] down the branch indicating that our cache was out of date and we're trying to recreate a revision.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2023
Copy link
Contributor

openshift-ci bot commented Dec 11, 2023

@ingvagabund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator 81c9577 link true /test e2e-aws-operator
ci/prow/unit 81c9577 link true /test unit
ci/prow/verify-deps 81c9577 link true /test verify-deps
ci/prow/security 81c9577 link false /test security
ci/prow/e2e-aws-operator-preferred-host 81c9577 link true /test e2e-aws-operator-preferred-host
ci/prow/verify 81c9577 link true /test verify
ci/prow/e2e-aws-ovn 81c9577 link true /test e2e-aws-ovn
ci/prow/images 81c9577 link true /test images
ci/prow/e2e-aws-ovn-upgrade 81c9577 link true /test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 15, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund
Copy link
Member Author

Synced through #770

@openshift-ci-robot
Copy link

@ingvagabund: This pull request references Jira Issue OCPBUGS-21846. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Validating for openshift/library-go#1641

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund deleted the sync-library-go-potential-race branch December 19, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants