Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug 2091033: Namespace filtering #255

Merged
merged 1 commit into from May 31, 2022
Merged

bug 2091033: Namespace filtering #255

merged 1 commit into from May 31, 2022

Conversation

ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Apr 28, 2022 •
edited

@openshift-ci openshift-ci bot requested review from mfojtik and soltysh April 28, 2022 14:37
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2022
@ingvagabund ingvagabund changed the title Namespace filtering bug 2091033: Namespace filtering May 27, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2022

@ingvagabund: This pull request references Bugzilla bug 2091033, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

bug 2091033: Namespace filtering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund
Copy link
Member Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2022

@ingvagabund: An error was encountered adding this pull request to the external tracker bugs for bug 2091033 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. JSONRPC error 32000: Red Hat Bugzilla's database reported a query serialization error. Most likely this occurred because another user or process attempted to change the same data that you were attempting to change. Please press Back and retry the transaction. 
 UPDATE bugs SET delta_ts = ? WHERE bug_id = ? at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1517.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund
Copy link
Member Author

/retest

@ingvagabund
Copy link
Member Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2022

@ingvagabund: This pull request references Bugzilla bug 2091033, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @kasturinarra

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from kasturinarra May 27, 2022 12:58
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

@ingvagabund: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

soltysh
soltysh approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, can be fixed in a followup.
/lgtm

pkg/operator/target_config_reconciler.go
includedNamespaces := []string{}
if descheduler.Spec.ProfileCustomizations != nil {
if len(descheduler.Spec.ProfileCustomizations.Namespaces.Excluded) > 0 && len(descheduler.Spec.ProfileCustomizations.Namespaces.Included) > 0 {
return nil, false, fmt.Errorf("It is forbidden to combine both included and excluded namespaces")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: all errors should start lowercase.

pkg/operator/target_config_reconciler.go
if len(descheduler.Spec.ProfileCustomizations.Namespaces.Included) > 0 {
for _, ns := range descheduler.Spec.ProfileCustomizations.Namespaces.Included {
if protectedNamespacesSet.Has(ns) {
return nil, false, fmt.Errorf("Protected namespace %v included. It is forbidden to include any of the protected namespaces from %v", ns, c.protectedNamespaces)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, wrt lowercase.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ingvagabund,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit cc2dc9b into openshift:master May 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

@ingvagabund: All pull requests linked via external trackers have merged:

Bugzilla bug 2091033 has been moved to the MODIFIED state.

In response to this:

bug 2091033: Namespace filtering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund deleted the namespace-filtering branch May 31, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

@kasturinarra kasturinarra Awaiting requested review from kasturinarra

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ingvagabund @soltysh @openshift-merge-robot