Bug 1788151: fix go.mod and bump library-go to pickup ipv6 change #196
Conversation
openshift-ci-robot
added
the
size/XXL
openshift-ci-robot
added
the
approved
| @@ -19,19 +19,4 @@ require ( | |||
| k8s.io/klog v1.0.0 | |||
| ) | |||
|
|
|||
| replace ( | |||
| github.com/jteeuwen/go-bindata => github.com/jteeuwen/go-bindata v3.0.8-0.20151023091102-a0ff2567cfb7+incompatible | |||
There was a problem hiding this comment.
go.mod in library-go [1] is now pinning the revisions, correct?
[1] https://github.com/openshift/library-go/blob/master/go.mod
There was a problem hiding this comment.
it is not, but this one does not seems to break nor need to be pinned?
There was a problem hiding this comment.
Dunno, though it can be always undone when needed. Just wondering what's better. Though, as long as the latest are compatible and acceptable, no nit here.
soltysh
changed the title
|
@mfojtik: An error was encountered adding this pull request to the external tracker bugs for bug 1788151 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, retroflexer, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mfojtik: All pull requests linked via external trackers have merged. Bugzilla bug 1788151 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@petr-muller: Bugzilla bug 1788151 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.