Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hold] Test bump to upstream rc1 prebase branches #264

Merged
merged 3 commits into from Jul 22, 2020
Merged

[hold] Test bump to upstream rc1 prebase branches #264

merged 3 commits into from Jul 22, 2020

Conversation

damemi
Copy link

@damemi damemi commented Jul 22, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020
soltysh
soltysh approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a30c2e6 into openshift:master Jul 22, 2020
@damemi
Copy link
Author

damemi commented Jul 22, 2020

oh didn't know we were merging this one, weird that "[hold]" in the title didn't add the hold label...

@deads2k
Copy link
Contributor

deads2k commented Jul 22, 2020

only [wip] works

nice job guys....

@damemi
Copy link
Author

damemi commented Jul 22, 2020

only [wip] works

nice job guys....

Is that intentional/recent? I've definitely held PRs with [hold] before, it's a different label than wip too

@soltysh
Copy link
Member

soltysh commented Jul 23, 2020

Is that intentional/recent? I've definitely held PRs with [hold] before, it's a different label than wip too

hold only works with / which you explicitly invoke, wip worked always

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@sttts sttts Awaiting requested review from sttts

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@damemi @openshift-ci-robot @deads2k @soltysh @openshift-merge-robot