[release-4.5] Bug 1874597: static-pod-installer: remove deadlock by recreating installers that disappear

[soltysh]

…allers that disappear

/assign @sttts

[openshift-ci-robot]

@soltysh: This pull request references Bugzilla bug 1874597, which is invalid:

• expected the bug to target the "4.6.0" release, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1874597: static-pod-installer: remove deadlock by recreating inst…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@soltysh: This pull request references Bugzilla bug 1874597, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.z) matches configured target release for branch (4.5.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1858763 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1858763 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
• bug has dependents

In response to this:

[release-4.5] Bug 1874597: static-pod-installer: remove deadlock by recreating inst…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@soltysh: This pull request references Bugzilla bug 1874597. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

[release-4.5] Bug 1874597: static-pod-installer: remove deadlock by recreating inst…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@soltysh: This pull request references Bugzilla bug 1874597, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.z) matches configured target release for branch (4.5.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1858763 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1858763 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
• bug has dependents

In response to this:

[release-4.5] Bug 1874597: static-pod-installer: remove deadlock by recreating inst…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[soltysh]

/retest

[ingvagabund]

/retest

[soltysh]

/retest

[damemi]

This prometheus flake is annoying, and I have no idea what causes it. We tried extending the timeout in #271 but that clearly isn't enough:

 --- FAIL: TestMetricsAccessible (30.84s)
    scheduler_test.go:317: prometheus returned unexpected results: timed out waiting for the condition
FAIL
FAIL	github.com/openshift/cluster-kube-scheduler-operator/test/e2e	43.570s
FAIL

[sttts]

/retest
/lgtm

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[xingxingxia]

/bugzilla cc-qa

[openshift-ci-robot]

@xingxingxia: This pull request references Bugzilla bug 1874597, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.z) matches configured target release for branch (4.5.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1858763 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1858763 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (kewang@redhat.com), skipping review request.

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wangke19]

/bugzilla cc-qa

[openshift-ci-robot]

@wangke19: This pull request references Bugzilla bug 1874597, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.z) matches configured target release for branch (4.5.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1858763 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1858763 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
• bug has dependents

Requesting review from QA contact:
/cc @wangke19

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wangke19]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, sttts, wangke19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [soltysh,sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wangke19]

Launched one 4.5 cluster with this PR successfully, it worked fine.

[markmc]

Risk assessment made difficult here because the critical 9 line fix we need ends up as a +749 −298 diff because of the necessary revendoring. Approving nonetheless, especially since we've merged this for ceo and ckao already.

[openshift-ci-robot]

@soltysh: All pull requests linked via external trackers have merged:

• openshift/library-go#879
• openshift/cluster-kube-scheduler-operator#278
• openshift/cluster-kube-controller-manager-operator#445
• openshift/cluster-kube-apiserver-operator#942
• openshift/cluster-etcd-operator#434

Bugzilla bug 1874597 has been moved to the MODIFIED state.

In response to this:

[release-4.5] Bug 1874597: static-pod-installer: remove deadlock by recreating installers that disappear

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.