Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gomod #377

Merged
merged 1 commit into from Nov 17, 2021
Merged

Fix gomod #377

merged 1 commit into from Nov 17, 2021

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Nov 15, 2021

Followup to #375

/assign @damemi

@openshift-ci openshift-ci bot requested review from damemi and sttts November 15, 2021 14:36
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2021
Copy link

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@soltysh
Copy link
Member Author

soltysh commented Nov 15, 2021

/hold for the other to merge

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2021
@soltysh
Copy link
Member Author

soltysh commented Nov 15, 2021

/retest

@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Nov 15, 2021
@soltysh
Copy link
Member Author

soltysh commented Nov 15, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2021
@soltysh
Copy link
Member Author

soltysh commented Nov 15, 2021

/retest

2 similar comments
@soltysh
Copy link
Member Author

soltysh commented Nov 16, 2021

/retest

@soltysh
Copy link
Member Author

soltysh commented Nov 16, 2021

/retest

@soltysh
Copy link
Member Author

soltysh commented Nov 16, 2021

/test e2e-aws

1 similar comment
@soltysh
Copy link
Member Author

soltysh commented Nov 16, 2021

/test e2e-aws

@ingvagabund
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [damemi,ingvagabund,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b9ea497 into openshift:master Nov 17, 2021
@soltysh soltysh deleted the fix_gomod branch November 17, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants