Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-23900: Profile customizations: dynamic resource allocation through TechPreviewNoUpgrade feature gate #532

Merged
merged 3 commits into from Feb 9, 2024
Merged

OCPBUGS-23900: Profile customizations: dynamic resource allocation through TechPreviewNoUpgrade feature gate #532

merged 3 commits into from Feb 9, 2024

Conversation

ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Jan 26, 2024 •
edited

Allow to enable Dynamic Resource Allocation functionality for available operator profiles.

Pulling openshift/api#1738

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 26, 2024
@openshift-ci-robot
Copy link

@ingvagabund: This pull request references Jira Issue OCPBUGS-23900, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @kasturinarra

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Allow to enable Dynamic Resource Allocation functionality for available operator profiles.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2024
@ingvagabund ingvagabund force-pushed the dra-scheduling-profile branch 2 times, most recently from 17c42bd to 3327317 Compare January 26, 2024 13:52
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2024
@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 8, 2024
Merged
@ingvagabund ingvagabund changed the title WIP: OCPBUGS-23900: Profile customizations: experimental DRA OCPBUGS-23900: Profile customizations: experimental DRA Feb 9, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2024
@ingvagabund
Copy link
Member Author

With default profile and customization set to ""/Disabled:

I0209 09:19:26.574790       1 configfile.go:101] "Using component config" config=<
        apiVersion: kubescheduler.config.k8s.io/v1
...
        profiles:
...
         plugins:
            bind: {}
            filter: {}
            multiPoint:
              enabled:
              - name: PrioritySort
                weight: 0
              - name: NodeUnschedulable
                weight: 0
              - name: NodeName
                weight: 0
              - name: TaintToleration
                weight: 3
              - name: NodeAffinity
                weight: 2
              - name: NodePorts
                weight: 0
              - name: NodeResourcesFit
                weight: 1
              - name: VolumeRestrictions
                weight: 0
              - name: EBSLimits
                weight: 0
              - name: GCEPDLimits
                weight: 0
              - name: NodeVolumeLimits
                weight: 0
              - name: AzureDiskLimits
                weight: 0
              - name: VolumeBinding
                weight: 0
              - name: VolumeZone
                weight: 0
              - name: PodTopologySpread
                weight: 2
              - name: InterPodAffinity
                weight: 2
              - name: DefaultPreemption
                weight: 0
              - name: NodeResourcesBalancedAllocation
                weight: 1
              - name: ImageLocality
                weight: 1
              - name: DefaultBinder
                weight: 0
              - name: SchedulingGates
                weight: 0
            permit: {}
            postBind: {}
            postFilter: {}
            preBind: {}
            preEnqueue: {}
            preFilter: {}
            preScore: {}
            queueSort: {}
            reserve: {}
            score: {}
          schedulerName: default-scheduler

@ingvagabund
Copy link
Member Author

With default profile and customization set to "Enabled":

I0209 09:55:57.789692       1 configfile.go:101] "Using component config" config=<
        apiVersion: kubescheduler.config.k8s.io/v1
...
          plugins:
            bind: {}
            filter: {}
            multiPoint:
              enabled:
              - name: PrioritySort
                weight: 0
              - name: NodeUnschedulable
                weight: 0
              - name: NodeName
                weight: 0
              - name: TaintToleration
                weight: 3
              - name: NodeAffinity
                weight: 2
              - name: NodePorts
                weight: 0
              - name: NodeResourcesFit
                weight: 1
              - name: VolumeRestrictions
                weight: 0
              - name: EBSLimits
                weight: 0
              - name: GCEPDLimits
                weight: 0
              - name: NodeVolumeLimits
                weight: 0
              - name: AzureDiskLimits
                weight: 0
              - name: VolumeBinding
                weight: 0
              - name: VolumeZone
                weight: 0
              - name: PodTopologySpread
                weight: 2
              - name: InterPodAffinity
                weight: 2
              - name: DefaultPreemption
                weight: 0
              - name: NodeResourcesBalancedAllocation
                weight: 1
              - name: ImageLocality
                weight: 1
              - name: DefaultBinder
                weight: 0
              - name: SchedulingGates
                weight: 0
              - name: DynamicResources
                weight: 0
            permit: {}
            postBind: {}
            postFilter: {}
            preBind: {}
            preEnqueue: {}
            preFilter: {}
            preScore: {}
            queueSort: {}
            reserve: {}
            score: {}
          schedulerName: default-scheduler
 >

@ingvagabund
Copy link
Member Author

With NoScoring profile and customization set to "Enabled":

          plugins:
            bind: {}
            filter: {}
            multiPoint:
              enabled:
              - name: PrioritySort
                weight: 0
              - name: NodeUnschedulable
                weight: 0
              - name: NodeName
                weight: 0
              - name: TaintToleration
                weight: 3
              - name: NodeAffinity
                weight: 2
              - name: NodePorts
                weight: 0
              - name: NodeResourcesFit
                weight: 1
              - name: VolumeRestrictions
                weight: 0
              - name: EBSLimits
                weight: 0
              - name: GCEPDLimits
                weight: 0
              - name: NodeVolumeLimits
                weight: 0
              - name: AzureDiskLimits
                weight: 0
              - name: VolumeBinding
                weight: 0
              - name: VolumeZone
                weight: 0
              - name: PodTopologySpread
                weight: 2
              - name: InterPodAffinity
                weight: 2
              - name: DefaultPreemption
                weight: 0
              - name: NodeResourcesBalancedAllocation
                weight: 1
              - name: ImageLocality
                weight: 1
              - name: DefaultBinder
                weight: 0
              - name: SchedulingGates
                weight: 0
              - name: DynamicResources
                weight: 0
            permit: {}
            postBind: {}
            postFilter: {}
            preBind: {}
            preEnqueue: {}
            preFilter: {}
            preScore:
              disabled:
              - name: '*'
                weight: 0
            queueSort: {}
            reserve: {}
            score:
              disabled:
              - name: '*'
                weight: 0
          schedulerName: default-scheduler
 >

@ingvagabund
Copy link
Member Author

With NoScoring profile and customization set to ""/Disabled:

         plugins:
            bind: {}
            filter: {}
            multiPoint:
              enabled:
              - name: PrioritySort
                weight: 0
              - name: NodeUnschedulable
                weight: 0
              - name: NodeName
                weight: 0
              - name: TaintToleration
                weight: 3
              - name: NodeAffinity
                weight: 2
              - name: NodePorts
                weight: 0
              - name: NodeResourcesFit
                weight: 1
              - name: VolumeRestrictions
                weight: 0
              - name: EBSLimits
                weight: 0
              - name: GCEPDLimits
                weight: 0
              - name: NodeVolumeLimits
                weight: 0
              - name: AzureDiskLimits
                weight: 0
              - name: VolumeBinding
                weight: 0
              - name: VolumeZone
                weight: 0
              - name: PodTopologySpread
                weight: 2
              - name: InterPodAffinity
                weight: 2
              - name: DefaultPreemption
                weight: 0
              - name: NodeResourcesBalancedAllocation
                weight: 1
              - name: ImageLocality
                weight: 1
              - name: DefaultBinder
                weight: 0
              - name: SchedulingGates
                weight: 0
            permit: {}
            postBind: {}
            postFilter: {}
            preBind: {}
            preEnqueue: {}
            preFilter: {}
            preScore:
              disabled:
              - name: '*'
                weight: 0
            queueSort: {}
            reserve: {}
            score:
              disabled:
              - name: '*'
                weight: 0
          schedulerName: default-scheduler
 >

@ingvagabund
Copy link
Member Author

With HighNodeUtilization profile and customization set to ""/Disabled:

          plugins:
            bind: {}
            filter: {}
            multiPoint:
              enabled:
              - name: PrioritySort
                weight: 0
              - name: NodeUnschedulable
                weight: 0
              - name: NodeName
                weight: 0
              - name: TaintToleration
                weight: 3
              - name: NodeAffinity
                weight: 2
              - name: NodePorts
                weight: 0
              - name: NodeResourcesFit
                weight: 1
              - name: VolumeRestrictions
                weight: 0
              - name: EBSLimits
                weight: 0
              - name: GCEPDLimits
                weight: 0
              - name: NodeVolumeLimits
                weight: 0
              - name: AzureDiskLimits
                weight: 0
              - name: VolumeBinding
                weight: 0
              - name: VolumeZone
                weight: 0
              - name: PodTopologySpread
                weight: 2
              - name: InterPodAffinity
                weight: 2
              - name: DefaultPreemption
                weight: 0
              - name: NodeResourcesBalancedAllocation
                weight: 1
              - name: ImageLocality
                weight: 1
              - name: DefaultBinder
                weight: 0
              - name: SchedulingGates
                weight: 0
            permit: {}
            postBind: {}
            postFilter: {}
            preBind: {}
            preEnqueue: {}
            preFilter: {}
            preScore: {}
            queueSort: {}
            reserve: {}
            score:
              disabled:
              - name: NodeResourcesBalancedAllocation
                weight: 0
              enabled:
              - name: NodeResourcesFit
                weight: 5
          schedulerName: default-scheduler
 >

@ingvagabund ingvagabund changed the title OCPBUGS-23900: Profile customizations: experimental DRA OCPBUGS-23900: Profile customizations: dynamic resource allocation through TechPreviewNoUpgrade feature gate Feb 9, 2024
@ingvagabund
Copy link
Member Author

With HighNodeUtilization profile and customization set to Enabled:

         plugins:
            bind: {}
            filter: {}
            multiPoint:
              enabled:
              - name: PrioritySort
                weight: 0
              - name: NodeUnschedulable
                weight: 0
              - name: NodeName
                weight: 0
              - name: TaintToleration
                weight: 3
              - name: NodeAffinity
                weight: 2
              - name: NodePorts
                weight: 0
              - name: NodeResourcesFit
                weight: 1
              - name: VolumeRestrictions
                weight: 0
              - name: EBSLimits
                weight: 0
              - name: GCEPDLimits
                weight: 0
              - name: NodeVolumeLimits
                weight: 0
              - name: AzureDiskLimits
                weight: 0
              - name: VolumeBinding
                weight: 0
              - name: VolumeZone
                weight: 0
              - name: PodTopologySpread
                weight: 2
              - name: InterPodAffinity
                weight: 2
              - name: DefaultPreemption
                weight: 0
              - name: NodeResourcesBalancedAllocation
                weight: 1
              - name: ImageLocality
                weight: 1
              - name: DefaultBinder
                weight: 0
              - name: SchedulingGates
                weight: 0
              - name: DynamicResources
                weight: 0
            permit: {}
            postBind: {}
            postFilter: {}
            preBind: {}
            preEnqueue: {}
            preFilter: {}
            preScore: {}
            queueSort: {}
            reserve: {}
            score:
              disabled:
              - name: NodeResourcesBalancedAllocation
                weight: 0
              enabled:
              - name: NodeResourcesFit
                weight: 5
          schedulerName: default-scheduler
 >

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 9, 2024

@ingvagabund: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knelasevero
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, knelasevero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ingvagabund,knelasevero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b2b7595 into openshift:master Feb 9, 2024
11 checks passed
@openshift-ci-robot
Copy link

@ingvagabund: Jira Issue OCPBUGS-23900: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23900 has been moved to the MODIFIED state.

In response to this:

Allow to enable Dynamic Resource Allocation functionality for available operator profiles.

Pulling openshift/api#1738

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ingvagabund ingvagabund deleted the dra-scheduling-profile branch February 9, 2024 12:38
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-scheduler-operator-container-v4.16.0-202402092208.p0.gb2b7595.assembly.stream.el9 for distgit ose-cluster-kube-scheduler-operator.
All builds following this will include this PR.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 12, 2024
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-02-17-013806

@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 1, 2024
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-03-05-105513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasturinarra kasturinarra Awaiting requested review from kasturinarra

@knelasevero knelasevero Awaiting requested review from knelasevero

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@knelasevero knelasevero

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ingvagabund @openshift-ci-robot @knelasevero @openshift-bot @openshift-merge-robot