Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotate kubeconfig #62

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions bindata/bootkube/manifests/kube-scheduler-secret-kubeconfig.yaml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: componentconfig/v1alpha1
kind: KubeSchedulerConfiguration
clientConnection:
kubeconfig: /etc/kubernetes/static-pod-resources/secrets/scheduler-kubeconfig/kubeconfig
kubeconfig: /etc/kubernetes/static-pod-resources/configmaps/scheduler-kubeconfig/kubeconfig
algorithmSource:
policy:
configMap:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: componentconfig/v1alpha1
kind: KubeSchedulerConfiguration
clientConnection:
kubeconfig: /etc/kubernetes/static-pod-resources/secrets/scheduler-kubeconfig/kubeconfig
kubeconfig: /etc/kubernetes/static-pod-resources/configmaps/scheduler-kubeconfig/kubeconfig
26 changes: 26 additions & 0 deletions bindata/v3.11.0/kube-scheduler/kubeconfig-cm.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
apiVersion: v1
kind: ConfigMap
metadata:
name: scheduler-kubeconfig
namespace: openshift-kube-scheduler
data:
kubeconfig: |
apiVersion: v1
clusters:
- cluster:
certificate-authority: /etc/kubernetes/static-pod-resources/configmaps/serviceaccount-ca/ca-bundle.crt
server: https://localhost:6443
name: loopback
contexts:
- context:
cluster: loopback
user: kube-scheduler
name: kube-scheduler
current-context: kube-scheduler
kind: Config
preferences: {}
users:
- name: kube-scheduler
user:
client-certificate: /etc/kubernetes/static-pod-resources/secrets/kube-scheduler-client-cert-key/tls.crt
client-key: /etc/kubernetes/static-pod-resources/secrets/kube-scheduler-client-cert-key/tls.key
11 changes: 11 additions & 0 deletions bindata/v3.11.0/kube-scheduler/leader-election-rolebinding.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
namespace: kube-system
name: system:openshift:leader-locking-kube-scheduler
roleRef:
kind: Role
name: system::leader-locking-kube-scheduler
subjects:
- kind: User
name: system:kube-scheduler
6 changes: 6 additions & 0 deletions pkg/operator/resourcesynccontroller/resourcesynccontroller.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,11 @@ func NewResourceSyncController(
resourcesynccontroller.ResourceLocation{Namespace: operatorclient.GlobalUserSpecifiedConfigNamespace, Name: "policy-configmap"}); err != nil {
return nil, err
}
if err := resourceSyncController.SyncSecret(
resourcesynccontroller.ResourceLocation{Namespace: operatorclient.TargetNamespace, Name: "kube-scheduler-client-cert-key"},
resourcesynccontroller.ResourceLocation{Namespace: operatorclient.GlobalMachineSpecifiedConfigNamespace, Name: "kube-scheduler-client-cert-key"},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sttts - This should solve the #53 too. Am I right?

); err != nil {
return nil, err
}
return resourceSyncController, nil
}
5 changes: 4 additions & 1 deletion pkg/operator/starter.go
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,14 @@ func RunOperator(ctx *controllercmd.ControllerContext) error {
// the first element should be the configmap that contains the static pod manifest
var deploymentConfigMaps = []revision.RevisionResource{
{Name: "kube-scheduler-pod"},

{Name: "config"},
{Name: "scheduler-kubeconfig"},
{Name: "serviceaccount-ca"},
{Name: "policy-configmap", Optional: true},
}

// deploymentSecrets is a list of secrets that are directly copied for the current values. A different actor/controller modifies these.
var deploymentSecrets = []revision.RevisionResource{
{Name: "scheduler-kubeconfig"},
{Name: "kube-scheduler-client-cert-key"},
}
23 changes: 23 additions & 0 deletions pkg/operator/target_config_reconciler_v311_00.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import (
"github.com/openshift/library-go/pkg/operator/resource/resourceapply"
"github.com/openshift/library-go/pkg/operator/resource/resourcemerge"
"github.com/openshift/library-go/pkg/operator/resource/resourceread"
"github.com/openshift/library-go/pkg/operator/resourcesynccontroller"
"github.com/openshift/library-go/pkg/operator/v1helpers"
)

Expand All @@ -28,6 +29,8 @@ func createTargetConfigReconciler_v311_00_to_latest(c TargetConfigReconciler, re

directResourceResults := resourceapply.ApplyDirectly(c.kubeClient, c.eventRecorder, v311_00_assets.Asset,
"v3.11.0/kube-scheduler/ns.yaml",
"v3.11.0/kube-scheduler/kubeconfig-cm.yaml",
"v3.11.0/kube-scheduler/leader-election-rolebinding.yaml",
"v3.11.0/kube-scheduler/scheduler-clusterrolebinding.yaml",
"v3.11.0/kube-scheduler/svc.yaml",
"v3.11.0/kube-scheduler/sa.yaml",
Expand All @@ -41,6 +44,10 @@ func createTargetConfigReconciler_v311_00_to_latest(c TargetConfigReconciler, re
if err != nil {
errors = append(errors, fmt.Errorf("%q: %v", "configmap", err))
}
_, _, err = manageServiceAccountCABundle(c.configMapLister, c.kubeClient.CoreV1(), recorder)
if err != nil {
errors = append(errors, fmt.Errorf("%q: %v", "configmap/serviceaccount-ca", err))
}
_, _, err = managePod_v311_00_to_latest(c.kubeClient.CoreV1(), recorder, operatorConfig, c.targetImagePullSpec)
if err != nil {
errors = append(errors, fmt.Errorf("%q: %v", "configmap/kube-scheduler-pod", err))
Expand Down Expand Up @@ -130,3 +137,19 @@ func managePod_v311_00_to_latest(client coreclientv1.ConfigMapsGetter, recorder
configMap.Data["version"] = version.Get().String()
return resourceapply.ApplyConfigMap(client, recorder, configMap)
}

func manageServiceAccountCABundle(lister corev1listers.ConfigMapLister, client coreclientv1.ConfigMapsGetter, recorder events.Recorder) (*corev1.ConfigMap, bool, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can now be reduced to a resourceSync against operatorclient.GlobalMachineSpecifiedConfigNamespace, Name: "kube-apiserver-server-ca"

requiredConfigMap, err := resourcesynccontroller.CombineCABundleConfigMaps(
resourcesynccontroller.ResourceLocation{Namespace: operatorclient.TargetNamespace, Name: "serviceaccount-ca"},
lister, client, recorder,
// include the ca bundle needed to recognize the server
resourcesynccontroller.ResourceLocation{Namespace: operatorclient.GlobalMachineSpecifiedConfigNamespace, Name: "kube-apiserver-server-ca"},
// include the ca bundle needed to recognize default
// certificates generated by cluster-ingress-operator
resourcesynccontroller.ResourceLocation{Namespace: operatorclient.GlobalMachineSpecifiedConfigNamespace, Name: "router-ca"},
)
if err != nil {
return nil, false, err
}
return resourceapply.ApplyConfigMap(client, recorder, requiredConfigMap)
}
81 changes: 79 additions & 2 deletions pkg/operator/v311_00_assets/bindata.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.