Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set cert-dir to prepare for 1.13 and switch to sercure port #77

Merged
merged 1 commit into from Apr 3, 2019
Merged

Set cert-dir to prepare for 1.13 and switch to sercure port #77

merged 1 commit into from Apr 3, 2019

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Mar 26, 2019

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 26, 2019
@deads2k
Copy link
Contributor

deads2k commented Mar 26, 2019

/lgtm

worked

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor

deads2k commented Mar 26, 2019

@sttts bootstrapping problem?

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2019
@mfojtik
Copy link
Member

mfojtik commented Mar 26, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2019
@mfojtik
Copy link
Member

mfojtik commented Mar 26, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sttts
Copy link
Contributor Author

sttts commented Mar 27, 2019

/retest

@soltysh
Copy link
Member

soltysh commented Mar 27, 2019

/lgtm cancel
@deads2k this won't merge b/c --cert-dir is not known to k8s 1.12, we need your nuclear option (#80) to land rebase

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2019
@soltysh soltysh mentioned this pull request Mar 27, 2019
Merged
@soltysh
Copy link
Member

soltysh commented Mar 27, 2019

/hold
We'll need to land the rebase first before doing this.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2019
@ravisantoshgudimetla
Copy link
Contributor

/retest

@ravisantoshgudimetla
Copy link
Contributor

@sttts - I am closing this one. Please re-open if you want this one.

@soltysh
Copy link
Member

soltysh commented Mar 29, 2019

We will need it for after the rebase lands.
/reopen

@openshift-ci-robot
Copy link

@soltysh: Reopened this PR.

In response to this:

We will need it for after the rebase lands.
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2019
@sttts
Copy link
Contributor Author

sttts commented Apr 3, 2019

Rebased landed.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2019
@mfojtik
Copy link
Member

mfojtik commented Apr 3, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4fe53aa into openshift:master Apr 3, 2019
@sttts sttts changed the title Set cert-dir to prepare for 1.13 Set cert-dir to prepare for 1.13 and switch to sercure port Apr 4, 2019
@sttts
Copy link
Contributor Author

sttts commented Apr 4, 2019

/cc @s-urbaniak

Shouldn't this break metrics for scheduler?

s-urbaniak
s-urbaniak reviewed Apr 4, 2019
View reviewed changes
bindata/v3.11.0/kube-scheduler/pod.yaml
@@ -16,8 +16,7 @@ spec:
command: ["hyperkube", "kube-scheduler"]
args:
- --config=/etc/kubernetes/static-pod-resources/configmaps/config/config.yaml
- --secure-port=0
- --port=10251
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/openshift/cluster-monitoring-operator/blob/172beb3e0d2cbf1f79bf61ba9c3f5bea373b4125/assets/prometheus-k8s/service-monitor-kube-scheduler.yaml#L15 relies on scraping the insecure port 10251 in the openshift-kube-scheduler namespace.

By ommitting --port, hyperkube kube-scheduler will still be listening on the insecure port 10251. Just explicitely setting it to --port=0 will disable the insecure port.

tldr: this shouldn't break monitoring and I verified with a local scheduler that, having ommitted --port i stil get metrics on 127.0.0.1:10251/metrics.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sttts I'm looking at our config which we point here and I don't see we set port to 10257 and insecure to 0, am I blind or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-urbaniak s-urbaniak s-urbaniak left review comments

@soltysh soltysh soltysh left review comments

@ravisantoshgudimetla ravisantoshgudimetla Awaiting requested review from ravisantoshgudimetla

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@mfojtik mfojtik

@soltysh soltysh

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@sttts @deads2k @openshift-bot @mfojtik @soltysh @ravisantoshgudimetla @openshift-ci-robot @s-urbaniak @openshift-merge-robot