Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "specify master node selector on migrator pod" #93

Merged

Conversation

stbenjam
Copy link
Member

Reverts #92 > ; tracked by OCPBUGS-18125

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This change has broken hypershift, and it is no longer installing. Hypershift fails on

error is version False True 30m Unable to apply 4.14.0-0.nightly-2023-08-25-105956: the cluster operator kube-storage-version-migrator is not available

It seems the deployment never succeeds:

 - lastTransitionTime: "2023-08-25T11:27:43Z"
    message: 'KubeStorageVersionMigratorProgressing: Waiting for Deployment to deploy
      pods'
    reason: KubeStorageVersionMigrator_Deploying
    status: "True"
    type: Progressing
  - lastTransitionTime: "2023-08-25T11:27:43Z"
    message: 'KubeStorageVersionMigratorAvailable: Waiting for Deployment'
    reason: KubeStorageVersionMigrator_Deploying
    status: "False"

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please check a hypershift job and ensure it succeeds.

CC: @sanchezl, @wangke19

@stbenjam
Copy link
Member Author

/skip
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-operator
/label approved

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2023

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws, ci/prow/e2e-aws-operator

In response to this:

/skip
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-operator
/label approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csrwng
Copy link
Contributor

csrwng commented Aug 25, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: csrwng, stbenjam
Once this PR has been reviewed and has the lgtm label, please assign p0lyn0mial for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@stbenjam
Copy link
Member Author

/label approved

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@stbenjam
Copy link
Member Author

/label jira/valid-bug

@openshift-ci openshift-ci bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 25, 2023
@openshift-merge-robot openshift-merge-robot merged commit 332cb1c into openshift:master Aug 25, 2023
7 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2023

@stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants