Update ClusterLogForwarder status when ClusterLogging becomes valid

After a valid ClusterLogForwarder and an invalid ClusterLogging resource
are created, the ClusterLogForwarder's status will show that the CLF is
not available. When the ClusterLogging CR is then changes to a valid
configuration, the CLF's status should reflect that everything is o.k.
now.

Signed-off-by: Andreas Karis <ak.karis@gmail.com>

controllers/clusterlogging/clusterlogging_controller.go

@@ -110,10 +110,18 @@ func (r *ReconcileClusterLogging) Reconcile(ctx context.Context, request ctrl.Re
 		telemetry.Data.CLInfo.Set("managedStatus", constants.UnManagedStatus)
 		return ctrl.Result{}, nil
 	}
-	clf, err, _ := loader.FetchClusterLogForwarder(r.Client, request.NamespacedName.Namespace, request.NamespacedName.Name, false, func() loggingv1.ClusterLogging { return instance })
+	clf, err, cls := loader.FetchClusterLogForwarder(r.Client, request.NamespacedName.Namespace, request.NamespacedName.Name, false, func() loggingv1.ClusterLogging { return instance })
 	if err != nil && !errors.IsNotFound(err) {
 		return ctrl.Result{}, err
 	}
+	// Make sure that the ClusterForwarder status is updated as well, as we might migrate from an invalid to a valid
+	// configuration or vice versa.
+	clf.Status.Synchronize(cls)
+	defer func() {
+		if err := r.Client.Status().Update(ctx, &clf); err != nil {
+			log.Error(err, "Error while updating status for ClusterLoggingForwarder %s/%s", clf.Namespace, clf.Name)
+		}
+	}()
 
 	clusterVersion, clusterID := r.GetClusterVersionID(ctx, request.Namespace)
 	resourceNames := factory.GenerateResourceNames(clf)