LOG-1681: Delay refresh to allow startup to bind metrics listener

[jcantrill]

Description

This PR delays in_tail file refresh watcher at startup to allow the metrics endpoint to bind and complete initialization.

cc @vimalk78 @syedriko

Links

• https://issues.redhat.com/browse/LOG-1681
• Input plugin does not expose port on arbitrary node fluent/fluent-plugin-prometheus#92
• 5.2 port of Bug 1929363: Delay refresh to allow startup to bind metrics listener #1133

[syedriko]

/lgtm
The alignment is off on new lines in the _test.go files

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, syedriko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[syedriko]

/test e2e-gcp

[jcantrill]

/cherrypick release-5.1

[openshift-cherrypick-robot]

@jcantrill: #1134 failed to apply on top of branch "release-5.1":

Applying: LOG-1681: Delay refresh to allow startup to bind metrics listener
Using index info to reconstruct a base tree...
M	pkg/generators/forwarding/fluentd/fluent_conf_test.go
M	pkg/generators/forwarding/fluentd/output_conf_legacy_test.go
M	pkg/generators/forwarding/fluentd/source_test.go
M	pkg/generators/forwarding/fluentd/templates.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/generators/forwarding/fluentd/templates.go
Auto-merging pkg/generators/forwarding/fluentd/source_test.go
CONFLICT (content): Merge conflict in pkg/generators/forwarding/fluentd/source_test.go
Auto-merging pkg/generators/forwarding/fluentd/output_conf_legacy_test.go
Auto-merging pkg/generators/forwarding/fluentd/fluent_conf_test.go
CONFLICT (content): Merge conflict in pkg/generators/forwarding/fluentd/fluent_conf_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 LOG-1681: Delay refresh to allow startup to bind metrics listener
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-5.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.