Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-1033: <transport tls> Prometheus config for fluentd 1.14 #1216

Merged
merged 1 commit into from Mar 25, 2022
Merged

LOG-1033: <transport tls> Prometheus config for fluentd 1.14 #1216

merged 1 commit into from Mar 25, 2022

Conversation

syedriko
Copy link
Contributor

@syedriko syedriko commented Oct 12, 2021 •
edited

Description

LOG-1033: Update fluentd to the latest version (1.14.1). Prometheus listener needs <transport tls> configuration to enable async HTTP server instead of Webrick. Otherwise, no functional changes.

/cc @jcantrill
/assign @vimalk78

Links

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2021
@openshift-ci openshift-ci bot requested a review from jcantrill October 12, 2021 00:18
@syedriko syedriko force-pushed the log_1033_new_prometheus_https_endpoint_config branch 2 times, most recently from 4470468 to d771d88 Compare October 12, 2021 01:03
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 10, 2022
@jcantrill
Copy link
Contributor

Blocked by ViaQ/logging-fluentd#2

@jcantrill
Copy link
Contributor

/retest

@jcantrill
Copy link
Contributor

@syedriko is this PR still valid after our move to 1.14.5. If so, please update or close

@jcantrill
Copy link
Contributor

/approve

@syedriko
LOG-1033: Update fluentd to the latest version (1.14.1).
c86db20 
Prometheus listener needs <transport tls> configuration to enable async HTTP server instead of Webrick.
@syedriko syedriko force-pushed the log_1033_new_prometheus_https_endpoint_config branch from d771d88 to c86db20 Compare March 16, 2022 19:56
@syedriko syedriko changed the title WIP: LOG-1033: Update fluentd to the latest version (1.14.1). <transport tls> Prometheus config LOG-1033: Update fluentd to the latest version (1.14.1). <transport tls> Prometheus config Mar 16, 2022
@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 16, 2022
@syedriko syedriko changed the title LOG-1033: Update fluentd to the latest version (1.14.1). <transport tls> Prometheus config LOG-1033: <transport tls> Prometheus config for fluentd 1.14 Mar 16, 2022
@syedriko
Copy link
Contributor Author

/test functional

5 similar comments
@syedriko
Copy link
Contributor Author

/test functional

@syedriko
Copy link
Contributor Author

/test functional

@syedriko
Copy link
Contributor Author

/test functional

@syedriko
Copy link
Contributor Author

/test functional

@syedriko
Copy link
Contributor Author

/test functional

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2022 •
edited

@syedriko: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp d771d88a60ec904b3902e520c0db334a25552f48 link true /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@syedriko
Copy link
Contributor Author

/test functional

jcantrill
jcantrill approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, syedriko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b4b4440 into openshift:master Mar 25, 2022
@syedriko syedriko deleted the log_1033_new_prometheus_https_endpoint_config branch March 25, 2022 14:21
pmoogi-redhat pushed a commit to pmoogi-redhat/cluster-logging-operator that referenced this pull request Apr 26, 2022
@openshift-merge-robot
Merge pull request openshift#1216 from syedriko/log_1033_new_promethe…
7eae629 
…us_https_endpoint_config

LOG-1033: <transport tls> Prometheus config for fluentd 1.14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcantrill jcantrill jcantrill approved these changes

Assignees

@vimalk78 vimalk78

@jcantrill jcantrill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@syedriko @openshift-bot @jcantrill @vimalk78 @openshift-merge-robot