Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2059996: Fix inability to tune read line limit when tuning buffers #1391

Merged
merged 1 commit into from Mar 30, 2022

Conversation

jcantrill
Copy link
Contributor

Description

This PR:

  • fixes the issue where there is a mismatch between buffer tuning and in tail readline limit
  • Introduces InTail tuning similar to Buffer tuning for fluentd
    /assign @alanconway

Links

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2022

@jcantrill: This pull request references Bugzilla bug 2059996, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anli@redhat.com), skipping review request.

In response to this:

Bug 2059996: Fix inability to tune read line limit when tuning buffers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2022
@jcantrill
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2022

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcantrill jcantrill added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 16, 2022
Copy link
Contributor

@alanconway alanconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alanconway,jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anpingli
Copy link

/lgtm

@anpingli
Copy link

label cherry-pick-approved

@anpingli
Copy link

/label cherry-pick-approved

@anpingli
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 29, 2022
@anpingli
Copy link

/label cherry-pick-approved

@anpingli
Copy link

/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2022

@anpingli: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers]

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcantrill jcantrill added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 30, 2022
@openshift-merge-robot openshift-merge-robot merged commit 68a0fbe into openshift:release-4.6 Mar 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2022

@jcantrill: All pull requests linked via external trackers have merged:

Bugzilla bug 2059996 has been moved to the MODIFIED state.

In response to this:

Bug 2059996: Fix inability to tune read line limit when tuning buffers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcantrill jcantrill deleted the bz2059996 branch March 30, 2022 13:03
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-logging-operator-container-v4.6.0-202311250021.p0.g68a0fbe.assembly.stream for distgit cluster-logging-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR release/4.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants