LOG-2294: Fix vector internal metrics not exposed via HTTPS #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcantrill
requested changes
Apr 13, 2022
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, Pranjal-Gupta2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
Update unit tests for vector conf generation Add e2e test to check logfilesmetricexporter metrics Remove env variable from tls key and crt parameter Signed-off-by: Pranjal-Gupta2 <pranjal.gupta2@ibm.com>
openshift-ci
bot
removed
the
needs-rebase
|
@Pranjal-Gupta2: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-ci
bot
removed
the
do-not-merge/hold
pmoogi-redhat
pushed a commit
to pmoogi-redhat/cluster-logging-operator
that referenced
this pull request
Apr 26, 2022
LOG-2294: Fix vector internal metrics not exposed via HTTPS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
logfilesmetricexporternot taking command line argumentslogfilesmetricexporterto use normalized paths (/etc/collector...)/cc @jcantrill @vimalk78
Links