Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-2063: fix deploying a collector with no CLF #1451

Merged
merged 1 commit into from
May 6, 2022
Merged

LOG-2063: fix deploying a collector with no CLF #1451

merged 1 commit into from
May 6, 2022

Conversation

jcantrill
Copy link
Contributor

@jcantrill jcantrill commented May 3, 2022 •
edited

Description

This PR:

  • fixes collector deployment when only a collector is defined and there is no CLF
  • Stops deployment of either fluent or vector
  • Refactors one test to be ginkgo table driven

Links

@jcantrill
Copy link
Contributor Author

cc @alanconway @vimalk78

@openshift-ci openshift-ci bot requested review from alanconway and eranra May 3, 2022 21:12
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2022
@jcantrill jcantrill force-pushed the log2063 branch 2 times, most recently from 63b98aa to d2943a7 Compare May 4, 2022 18:04
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2022

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

alanconway
alanconway approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@alanconway alanconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alanconway,jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5623776 into openshift:master May 6, 2022
@jcantrill jcantrill deleted the log2063 branch May 6, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanconway alanconway alanconway approved these changes

@eranra eranra Awaiting requested review from eranra

Assignees

@alanconway alanconway

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcantrill @alanconway @openshift-merge-robot